Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Workflow for Docker build/push enhancements #1003

Closed
justb4 opened this issue Sep 29, 2022 · 5 comments
Closed

GitHub Workflow for Docker build/push enhancements #1003

justb4 opened this issue Sep 29, 2022 · 5 comments
Labels
enhancement New feature or request stale Issue marked stale by stale-bot

Comments

@justb4
Copy link
Member

justb4 commented Sep 29, 2022

Is your feature request related to a problem? Please describe.
This concerns the GH Workflow containers.yml.
Via #989 and PR #997 the Docker Build/Push is working but there are some 'dangling issues', at least two:

Describe the solution you'd like

  • run the Unit Tests in Docker like docker run --entrypoint "/entrypoint.sh" --rm geopython/pygeoapi:tag test
  • If outcome of the tests is negative: Fail the Workflow, do not publish the Image (now it will chug along)
  • See if Docker Image can be built only once (if really built twice)

Describe alternatives you've considered
SOme projects see to use a GH Workflow Cron to test/analyze code Docker Images, but that would defeat Images already rolled out...

Additional context
N.A.

@KoalaGeo
Copy link
Contributor

containers.yml won't run until the build stage (main.yml) is complete and the testing therefore passed (https://github.com/geopython/pygeoapi/blob/master/.github/workflows/containers.yml#L11)

So we could potentially remove the testing of the built containers although I can understand why might want to include as a double check...

@justb4
Copy link
Member Author

justb4 commented Sep 29, 2022

Yes, please also use the tests within the Container. The execution/version context is usually different from other execution contexts like local venvs and even the GH Workflow, this based on e.g. Ubuntu versions, non-pinned PyPi packages etc. Even timezones may matter. Plus the context within the container is more complete, e.g. it has GDAL, while this is not (yet) in the Build workflow (commented out). Though we should have reproducible builds, in practice this is very hard.

@justb4
Copy link
Member Author

justb4 commented Jan 18, 2023

Is similar to #344 and now worked on in #1105 so I propose to close here as duplicate.

Copy link

As per RFC4, this Issue has been inactive for 90 days. In order to manage maintenance burden, it will be automatically closed in 7 days.

@github-actions github-actions bot added the stale Issue marked stale by stale-bot label Mar 10, 2024
Copy link

As per RFC4, this Issue has been closed due to there being no activity for more than 90 days.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale Issue marked stale by stale-bot
Projects
None yet
Development

No branches or pull requests

2 participants