-
-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Workflow for Docker build/push enhancements #1003
Comments
So we could potentially remove the testing of the built containers although I can understand why might want to include as a double check... |
Yes, please also use the tests within the Container. The execution/version context is usually different from other execution contexts like local venvs and even the GH Workflow, this based on e.g. Ubuntu versions, non-pinned PyPi packages etc. Even timezones may matter. Plus the context within the container is more complete, e.g. it has GDAL, while this is not (yet) in the Build workflow (commented out). Though we should have reproducible builds, in practice this is very hard. |
As per RFC4, this Issue has been inactive for 90 days. In order to manage maintenance burden, it will be automatically closed in 7 days. |
As per RFC4, this Issue has been closed due to there being no activity for more than 90 days. |
Is your feature request related to a problem? Please describe.
This concerns the GH Workflow containers.yml.
Via #989 and PR #997 the Docker Build/Push is working but there are some 'dangling issues', at least two:
Describe the solution you'd like
docker run --entrypoint "/entrypoint.sh" --rm geopython/pygeoapi:tag test
Describe alternatives you've considered
SOme projects see to use a GH Workflow Cron to test/analyze code Docker Images, but that would defeat Images already rolled out...
Additional context
N.A.
The text was updated successfully, but these errors were encountered: