Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: html repr not legible in dark themes #66

Closed
martinfleis opened this issue Aug 5, 2021 · 2 comments · Fixed by #70
Closed

BUG: html repr not legible in dark themes #66

martinfleis opened this issue Aug 5, 2021 · 2 comments · Fixed by #70
Labels
bug Something isn't working
Milestone
2021.08

Comments

@martinfleis
Copy link
Member

Our HTML repr works only in light IDE themes like the default JLab. Dark mode makes it illegible.

Screenshot 2021-08-05 at 11 08 18
@martinfleis martinfleis added this to the 2021.08 milestone Aug 5, 2021
@martinfleis martinfleis added the bug Something isn't working label Aug 5, 2021
@benbovy
Copy link

benbovy commented Aug 5, 2021

Since you have been inspired by xarray for this repr, I just want to mention the following PRs in case you haven't checked it yet:

(more off-topic: I also like the recently added reprs for dask clusters and clients, e.g., dask/distributed#4857)

@martinfleis
Copy link
Member Author

@benbovy thanks a lot for the references! It looks like a lot of fun ahead.

@martinfleis martinfleis mentioned this issue Aug 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
2021.08
Development

Successfully merging a pull request may close this issue.

ENH: support dark themes in HTML repr martinfleis/xyzservices
2 participants
@benbovy @martinfleis