Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

custom JSON library support #3

Merged
merged 1 commit into from
Aug 9, 2021
Merged

custom JSON library support #3

merged 1 commit into from
Aug 9, 2021

Conversation

mwhitworth
Copy link
Contributor

We found that another library performed better on a large document we send over GraphQL, so it would be useful to have the option.

@sax
Copy link
Collaborator

sax commented Aug 9, 2021

This is great!

I'm curious which json library you preferred? Jason seems like an uncontroversial default at the moment, but I might do some benchmarks and add documentation about them.

@sax sax merged commit 9e8f893 into absinthe-graphql:main Aug 9, 2021
@mwhitworth
Copy link
Contributor Author

eljiffy, which seemed to perform quite well on a 10MB-size JSON we return over GraphQL (and which was the main performance issue for us with Absinthe in general)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mwhitworth @sax