From 354a63678d2166cc520f6938638bf98252b80bab Mon Sep 17 00:00:00 2001 From: bananabrann Date: Tue, 1 Aug 2023 21:24:04 -0500 Subject: [PATCH 1/4] Add keepNames to esbuild options --- index.d.ts | 2 +- index.js | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/index.d.ts b/index.d.ts index ee46ac4..846a3e3 100644 --- a/index.d.ts +++ b/index.d.ts @@ -8,7 +8,7 @@ export * from './types/swa'; export type Options = { debug?: boolean; customStaticWebAppConfig?: CustomStaticWebAppConfig; - esbuildOptions?: Pick; + esbuildOptions?: Pick; apiDir?: string; staticDir?: string; allowReservedSwaRoutes?: boolean; diff --git a/index.js b/index.js index c0ad9c0..dc32528 100644 --- a/index.js +++ b/index.js @@ -131,7 +131,8 @@ If you want to suppress this error, set allowReservedSwaRoutes to true in your a platform: 'node', target: 'node16', sourcemap: 'linked', - external: esbuildOptions.external + external: esbuildOptions.external, + keepNames: esbuildOptions.keepNames }; await esbuild.build(default_options); From 86e0d5e98ec912ffed71ee6cb60bb5ae79ac34fb Mon Sep 17 00:00:00 2001 From: bananabrann Date: Wed, 2 Aug 2023 07:31:37 -0500 Subject: [PATCH 2/4] Add keep-names information to esbuildOptions section --- README.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 728aac6..da07acc 100644 --- a/README.md +++ b/README.md @@ -196,7 +196,7 @@ export default { ### esbuildOptions -An object containing additional [esbuild options](https://esbuild.github.io/api/#build-api). Currently only supports [external](https://esbuild.github.io/api/#external). If you require additional options to be exposed, plese [open an issue](https://github.com/geoffrich/svelte-adapter-azure-swa/issues). +An object containing additional [esbuild options](https://esbuild.github.io/api/#build-api). Currently only supports [external](https://esbuild.github.io/api/#external) and [keep-names](https://esbuild.github.io/api/#keep-names). If you require additional options to be exposed, plese [open an issue](https://github.com/geoffrich/svelte-adapter-azure-swa/issues). ```js import azure from 'svelte-adapter-azure-swa'; @@ -206,7 +206,8 @@ export default { ... adapter: azure({ esbuildOptions: { - external: ['fsevents'] + external: ['fsevents'], + keepNames: [true, false] } }) } From 1cee49287deebff8415e681255f737355cf3e6d3 Mon Sep 17 00:00:00 2001 From: bananabrann Date: Thu, 3 Aug 2023 08:16:10 -0500 Subject: [PATCH 3/4] Change readme section from list of options to example Co-authored-by: Tobias Laundal --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index da07acc..4e03631 100644 --- a/README.md +++ b/README.md @@ -207,7 +207,7 @@ export default { adapter: azure({ esbuildOptions: { external: ['fsevents'], - keepNames: [true, false] + keepNames: true } }) } From 84491aa3bb3927689961525657f126f291992024 Mon Sep 17 00:00:00 2001 From: Geoff Rich <4992896+geoffrich@users.noreply.github.com> Date: Thu, 3 Aug 2023 15:55:34 -0700 Subject: [PATCH 4/4] docs: fix typos --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 4e03631..e74871d 100644 --- a/README.md +++ b/README.md @@ -196,7 +196,7 @@ export default { ### esbuildOptions -An object containing additional [esbuild options](https://esbuild.github.io/api/#build-api). Currently only supports [external](https://esbuild.github.io/api/#external) and [keep-names](https://esbuild.github.io/api/#keep-names). If you require additional options to be exposed, plese [open an issue](https://github.com/geoffrich/svelte-adapter-azure-swa/issues). +An object containing additional [esbuild options](https://esbuild.github.io/api/#build-api). Currently only supports [external](https://esbuild.github.io/api/#external) and [keepNames](https://esbuild.github.io/api/#keep-names). If you require additional options to be exposed, please [open an issue](https://github.com/geoffrich/svelte-adapter-azure-swa/issues). ```js import azure from 'svelte-adapter-azure-swa';