Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gs7 updateUpdate Here Geocode and Reverse Geocode Provider to GS7 (v7) #1231

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Gs7 updateUpdate Here Geocode and Reverse Geocode Provider to GS7 (v7) #1231

wants to merge 18 commits into from

Conversation

SCatrinh
Copy link

@SCatrinh SCatrinh commented Jul 3, 2024 •
edited
Loading

Updates Here provider to support GS7 under the 0.8.0 version tag. Details in linked issue

Closes #1230

SCatrinh added 18 commits June 24, 2024 17:12
@SCatrinh
replace cached here.com responses with responses from GS7 endpoints
b89b41e
@SCatrinh
update deprecated has attribute to has property
608c9c0
@SCatrinh
Updated geocode query to allow support for qualified queries
72a671d
@SCatrinh
update from here v6.2 to here v7 api (GS7)
da43505
@SCatrinh
Update with additional data to parse properly
70cdb6e
@SCatrinh
Update unit tests and integration tests
b3e83a4
@SCatrinh
remove unused import, remove extra white space, update Changelog
68afaa8
@SCatrinh
clean up some logic, move duplicated params to be parsed in a seperat…
9da8ad0 
…e method.
@SCatrinh
clean up exception annotations
3c1cb54
@SCatrinh
put empty string check back since we have updated the function param …
d03fd1b 
…to accept null
@SCatrinh
added a note for postalCodeDetails since here's implementation is not…
654e967 
… returning postal code details properly
@SCatrinh
revert deprecation update as per comments on geocoder-php/Geocoder PR…
65792e1 
… 1217
@SCatrinh
Add support in php-common for building queries with alternative methods
8425c0e
@SCatrinh
Revert "Add support in php-common for building queries with alternati…
ad0a926 
…ve methods"

This reverts commit 8425c0e.
@SCatrinh
Revert "Updated geocode query to allow support for qualified queries"
fa1b5ce 
This reverts commit 72a671d.
@SCatrinh
Revert "Update with additional data to parse properly"
b2b19a5 
This reverts commit 70cdb6e.
@SCatrinh
Added boolean param for using qualified query instead of regular query
5cbd114
@SCatrinh
Updated here test for qualified query, update cached response for test
f636bed
@SCatrinh SCatrinh marked this pull request as ready for review July 3, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
need rebase provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Here Geocode and Reverse Geocode Provider to GS7 (v7)
2 participants
@SCatrinh @jbelien