Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include_object missing since 0.12 - Breaks Alembic migrations #387

Closed
Timusan opened this issue Jul 20, 2022 · 4 comments · Fixed by #388
Closed

include_object missing since 0.12 - Breaks Alembic migrations #387

Timusan opened this issue Jul 20, 2022 · 4 comments · Fixed by #388

Comments

@Timusan
Copy link

Timusan commented Jul 20, 2022

In previous versions of Geoalchemy we had to import include_object and add it to our context in the Alembic setup:

    context.configure(
        url=get_url(),
        target_metadata=target_metadata,
        literal_binds=True,
        dialect_opts={"paramstyle": "named"},
        render_item=render_item,
        include_object=include_object,
    )

This was needed so that Alembic would not try to drop and recreate PostGIS tables.
Did I miss some change from 0.11.1 to 0.12?

@adrien-berchet adrien-berchet linked a pull request Jul 20, 2022 that will close this issue
@adrien-berchet
Copy link
Member

Hi @Timusan !
Thank you for your report. Indeed I removed it at some point when I was fixing all this Alembic mess and I forgot to revert it (and update it), sorry about that. Could you try the branch of #388 on your use case please?

@Timusan
Copy link
Author

Timusan commented Jul 25, 2022

Sorry for the late reply. I can confirm that your branch in #338 fixes the issue! 🎉

@adrien-berchet
Copy link
Member

No problem, thank you very much for testing, I will merge this a release a new version.

@adrien-berchet
Copy link
Member

https://pypi.org/project/GeoAlchemy2/0.12.2/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants