From bbd312b9cc082173dced104e46cf9da8da61e08a Mon Sep 17 00:00:00 2001 From: Gen Lu Date: Fri, 9 Oct 2020 14:05:59 -0700 Subject: [PATCH] Remove import completion experiment and enable it by default --- ...sionMethodImportCompletionProviderTests.cs | 3 -- .../TypeImportCompletionProviderTests.cs | 49 ++----------------- .../AsyncCompletion/CompletionSource.cs | 4 +- .../CSharpCompletionCommandHandlerTests.vb | 2 - ...sionMethodImportCompletionProviderTests.vb | 7 --- .../TypeImportCompletionProviderTests.vb | 4 -- .../Portable/Completion/CompletionOptions.cs | 3 +- .../AbstractImportCompletionProvider.cs | 21 +------- .../CSharp/Impl/CSharpVSResources.resx | 2 +- .../CSharp/Impl/xlf/CSharpVSResources.cs.xlf | 4 +- .../CSharp/Impl/xlf/CSharpVSResources.de.xlf | 4 +- .../CSharp/Impl/xlf/CSharpVSResources.es.xlf | 4 +- .../CSharp/Impl/xlf/CSharpVSResources.fr.xlf | 4 +- .../CSharp/Impl/xlf/CSharpVSResources.it.xlf | 4 +- .../CSharp/Impl/xlf/CSharpVSResources.ja.xlf | 4 +- .../CSharp/Impl/xlf/CSharpVSResources.ko.xlf | 4 +- .../CSharp/Impl/xlf/CSharpVSResources.pl.xlf | 4 +- .../Impl/xlf/CSharpVSResources.pt-BR.xlf | 4 +- .../CSharp/Impl/xlf/CSharpVSResources.ru.xlf | 4 +- .../CSharp/Impl/xlf/CSharpVSResources.tr.xlf | 4 +- .../Impl/xlf/CSharpVSResources.zh-Hans.xlf | 4 +- .../Impl/xlf/CSharpVSResources.zh-Hant.xlf | 4 +- .../VisualBasicCompletionSnippetNoteTests.vb | 4 ++ .../VisualBasic/Impl/BasicVSResources.resx | 2 +- .../Impl/xlf/BasicVSResources.cs.xlf | 4 +- .../Impl/xlf/BasicVSResources.de.xlf | 4 +- .../Impl/xlf/BasicVSResources.es.xlf | 4 +- .../Impl/xlf/BasicVSResources.fr.xlf | 4 +- .../Impl/xlf/BasicVSResources.it.xlf | 4 +- .../Impl/xlf/BasicVSResources.ja.xlf | 4 +- .../Impl/xlf/BasicVSResources.ko.xlf | 4 +- .../Impl/xlf/BasicVSResources.pl.xlf | 4 +- .../Impl/xlf/BasicVSResources.pt-BR.xlf | 4 +- .../Impl/xlf/BasicVSResources.ru.xlf | 4 +- .../Impl/xlf/BasicVSResources.tr.xlf | 4 +- .../Impl/xlf/BasicVSResources.zh-Hans.xlf | 4 +- .../Impl/xlf/BasicVSResources.zh-Hant.xlf | 4 +- .../Experiments/IExperimentationService.cs | 1 - 38 files changed, 66 insertions(+), 140 deletions(-) diff --git a/src/EditorFeatures/CSharpTest/Completion/CompletionProviders/ExtensionMethodImportCompletionProviderTests.cs b/src/EditorFeatures/CSharpTest/Completion/CompletionProviders/ExtensionMethodImportCompletionProviderTests.cs index 7c3c35951a8c2..88939fa3321fd 100644 --- a/src/EditorFeatures/CSharpTest/Completion/CompletionProviders/ExtensionMethodImportCompletionProviderTests.cs +++ b/src/EditorFeatures/CSharpTest/Completion/CompletionProviders/ExtensionMethodImportCompletionProviderTests.cs @@ -38,9 +38,6 @@ protected override OptionSet WithChangedOptions(OptionSet options) .WithChangedOption(CompletionOptions.HideAdvancedMembers, LanguageNames.CSharp, HideAdvancedMembers); } - protected override TestComposition GetComposition() - => base.GetComposition().AddParts(typeof(TestExperimentationService)); - internal override Type GetCompletionProviderType() => typeof(ExtensionMethodImportCompletionProvider); diff --git a/src/EditorFeatures/CSharpTest/Completion/CompletionProviders/TypeImportCompletionProviderTests.cs b/src/EditorFeatures/CSharpTest/Completion/CompletionProviders/TypeImportCompletionProviderTests.cs index c964510fa0343..be57917cb7fd1 100644 --- a/src/EditorFeatures/CSharpTest/Completion/CompletionProviders/TypeImportCompletionProviderTests.cs +++ b/src/EditorFeatures/CSharpTest/Completion/CompletionProviders/TypeImportCompletionProviderTests.cs @@ -11,7 +11,7 @@ using System.Threading.Tasks; using Microsoft.CodeAnalysis.Completion; using Microsoft.CodeAnalysis.CSharp.Completion.Providers; -using Microsoft.CodeAnalysis.Experiments; +using Microsoft.CodeAnalysis.Editor.UnitTests.Workspaces; using Microsoft.CodeAnalysis.Options; using Microsoft.CodeAnalysis.Test.Utilities; using Roslyn.Test.Utilities; @@ -42,48 +42,11 @@ protected override OptionSet WithChangedOptions(OptionSet options) .WithChangedOption(CompletionOptions.HideAdvancedMembers, LanguageNames.CSharp, HideAdvancedMembers); } - protected override TestComposition GetComposition() - => base.GetComposition().AddParts(typeof(TestExperimentationService)); - #region "Option tests" [Fact, Trait(Traits.Feature, Traits.Features.Completion)] - public async Task OptionSetToNull_ExpEnabled() - { - SetExperimentOption(WellKnownExperimentNames.TypeImportCompletion, true); - - ShowImportCompletionItemsOptionValue = null; - - var markup = @" -class Bar -{ - $$ -}"; - - await VerifyAnyItemExistsAsync(markup); - } - - [Fact, Trait(Traits.Feature, Traits.Features.Completion)] - public async Task OptionSetToNull_ExpDisabled() - { - ShowImportCompletionItemsOptionValue = null; - IsExpandedCompletion = false; - var markup = @" -class Bar -{ - $$ -}"; - - await VerifyNoItemsExistAsync(markup); - } - - [InlineData(true)] - [InlineData(false)] - [Theory, Trait(Traits.Feature, Traits.Features.Completion)] - public async Task OptionSetToFalse(bool isExperimentEnabled) + public async Task OptionSetToFalse() { - SetExperimentOption(WellKnownExperimentNames.TypeImportCompletion, isExperimentEnabled); - ShowImportCompletionItemsOptionValue = false; IsExpandedCompletion = false; @@ -96,13 +59,9 @@ class Bar await VerifyNoItemsExistAsync(markup); } - [InlineData(true)] - [InlineData(false)] - [Theory, Trait(Traits.Feature, Traits.Features.Completion)] - public async Task OptionSetToTrue(bool isExperimentEnabled) + [Fact, Trait(Traits.Feature, Traits.Features.Completion)] + public async Task OptionSetToTrue() { - SetExperimentOption(WellKnownExperimentNames.TypeImportCompletion, isExperimentEnabled); - ShowImportCompletionItemsOptionValue = true; var markup = @" diff --git a/src/EditorFeatures/Core/Implementation/IntelliSense/AsyncCompletion/CompletionSource.cs b/src/EditorFeatures/Core/Implementation/IntelliSense/AsyncCompletion/CompletionSource.cs index 36a635357373f..89c56640f6050 100644 --- a/src/EditorFeatures/Core/Implementation/IntelliSense/AsyncCompletion/CompletionSource.cs +++ b/src/EditorFeatures/Core/Implementation/IntelliSense/AsyncCompletion/CompletionSource.cs @@ -139,9 +139,7 @@ static void CheckForExperimentStatus(ITextView textView, Document document) var experimentationService = workspace.Services.GetService(); textView.Properties[TargetTypeFilterExperimentEnabled] = experimentationService.IsExperimentEnabled(WellKnownExperimentNames.TargetTypedCompletionFilter); - var importCompletionOptionValue = workspace.Options.GetOption(CompletionOptions.ShowItemsFromUnimportedNamespaces, document.Project.Language); - var importCompletionExperimentValue = experimentationService.IsExperimentEnabled(WellKnownExperimentNames.TypeImportCompletion); - var isTypeImportEnababled = importCompletionOptionValue == true || (importCompletionOptionValue == null && importCompletionExperimentValue); + var isTypeImportEnababled = workspace.Options.GetOption(CompletionOptions.ShowItemsFromUnimportedNamespaces, document.Project.Language) != false; textView.Properties[TypeImportCompletionEnabled] = isTypeImportEnababled; } } diff --git a/src/EditorFeatures/Test2/IntelliSense/CSharpCompletionCommandHandlerTests.vb b/src/EditorFeatures/Test2/IntelliSense/CSharpCompletionCommandHandlerTests.vb index d6747d912d4b4..8748b114b6777 100644 --- a/src/EditorFeatures/Test2/IntelliSense/CSharpCompletionCommandHandlerTests.vb +++ b/src/EditorFeatures/Test2/IntelliSense/CSharpCompletionCommandHandlerTests.vb @@ -7024,7 +7024,6 @@ namespace NS class ATaAaSaKa { } } , - extraExportedTypes:={GetType(TestExperimentationService)}.ToList(), showCompletionInArgumentLists:=showCompletionInArgumentLists) Dim workspace = state.Workspace @@ -7079,7 +7078,6 @@ namespace NS2 class MyTask3 { } } , - extraExportedTypes:={GetType(TestExperimentationService)}.ToList(), showCompletionInArgumentLists:=showCompletionInArgumentLists) Dim workspace = state.Workspace diff --git a/src/EditorFeatures/VisualBasicTest/Completion/CompletionProviders/ExtensionMethodImportCompletionProviderTests.vb b/src/EditorFeatures/VisualBasicTest/Completion/CompletionProviders/ExtensionMethodImportCompletionProviderTests.vb index 50407021e6f82..c98bf7a3cb4f2 100644 --- a/src/EditorFeatures/VisualBasicTest/Completion/CompletionProviders/ExtensionMethodImportCompletionProviderTests.vb +++ b/src/EditorFeatures/VisualBasicTest/Completion/CompletionProviders/ExtensionMethodImportCompletionProviderTests.vb @@ -16,18 +16,11 @@ Namespace Microsoft.CodeAnalysis.Editor.VisualBasic.UnitTests.Completion.Complet Private Property ShowImportCompletionItemsOptionValue As Boolean = True - ' -1 would disable timebox, whereas 0 means always timeout. - Private Property TimeoutInMilliseconds As Integer = -1 - Protected Overrides Function WithChangedOptions(options As OptionSet) As OptionSet Return options _ .WithChangedOption(CompletionOptions.ShowItemsFromUnimportedNamespaces, LanguageNames.VisualBasic, ShowImportCompletionItemsOptionValue).WithChangedOption(CompletionServiceOptions.IsExpandedCompletion, IsExpandedCompletion) End Function - Protected Overrides Function GetComposition() As TestComposition - Return MyBase.GetComposition().AddParts(GetType(TestExperimentationService)) - End Function - Friend Overrides Function GetCompletionProviderType() As Type Return GetType(ExtensionMethodImportCompletionProvider) End Function diff --git a/src/EditorFeatures/VisualBasicTest/Completion/CompletionProviders/TypeImportCompletionProviderTests.vb b/src/EditorFeatures/VisualBasicTest/Completion/CompletionProviders/TypeImportCompletionProviderTests.vb index e9ffa2c497269..a2695cb3ddad1 100644 --- a/src/EditorFeatures/VisualBasicTest/Completion/CompletionProviders/TypeImportCompletionProviderTests.vb +++ b/src/EditorFeatures/VisualBasicTest/Completion/CompletionProviders/TypeImportCompletionProviderTests.vb @@ -22,10 +22,6 @@ Namespace Microsoft.CodeAnalysis.Editor.VisualBasic.UnitTests.Completion.Complet .WithChangedOption(CompletionServiceOptions.IsExpandedCompletion, IsExpandedCompletion) End Function - Protected Overrides Function GetComposition() As TestComposition - Return MyBase.GetComposition().AddParts(GetType(TestExperimentationService)) - End Function - Friend Overrides Function GetCompletionProviderType() As Type Return GetType(TypeImportCompletionProvider) End Function diff --git a/src/Features/Core/Portable/Completion/CompletionOptions.cs b/src/Features/Core/Portable/Completion/CompletionOptions.cs index b086c3d9ba761..80516f0f65fda 100644 --- a/src/Features/Core/Portable/Completion/CompletionOptions.cs +++ b/src/Features/Core/Portable/Completion/CompletionOptions.cs @@ -54,9 +54,8 @@ internal static class CompletionOptions //Dev16 options - // Use tri-value so the default state can be used to turn on the feature with experimentation service. public static readonly PerLanguageOption2 ShowItemsFromUnimportedNamespaces = - new(nameof(CompletionOptions), nameof(ShowItemsFromUnimportedNamespaces), defaultValue: null, + new(nameof(CompletionOptions), nameof(ShowItemsFromUnimportedNamespaces), defaultValue: true, storageLocations: new RoamingProfileStorageLocation("TextEditor.%LANGUAGE%.Specific.ShowItemsFromUnimportedNamespaces")); // Use tri-value so the default state can be used to turn on the feature with experimentation service. diff --git a/src/Features/Core/Portable/Completion/Providers/ImportCompletionProvider/AbstractImportCompletionProvider.cs b/src/Features/Core/Portable/Completion/Providers/ImportCompletionProvider/AbstractImportCompletionProvider.cs index f7064b522dfdf..7c7e2667e2925 100644 --- a/src/Features/Core/Portable/Completion/Providers/ImportCompletionProvider/AbstractImportCompletionProvider.cs +++ b/src/Features/Core/Portable/Completion/Providers/ImportCompletionProvider/AbstractImportCompletionProvider.cs @@ -8,7 +8,6 @@ using System.Threading.Tasks; using Microsoft.CodeAnalysis.AddImports; using Microsoft.CodeAnalysis.Editing; -using Microsoft.CodeAnalysis.Experiments; using Microsoft.CodeAnalysis.Formatting; using Microsoft.CodeAnalysis.LanguageServices; using Microsoft.CodeAnalysis.PooledObjects; @@ -32,19 +31,6 @@ internal abstract class AbstractImportCompletionProvider : LSPCompletionProvider internal override bool IsExpandItemProvider => true; - private bool? _isImportCompletionExperimentEnabled = null; - - private bool IsExperimentEnabled(Workspace workspace) - { - if (!_isImportCompletionExperimentEnabled.HasValue) - { - var experimentationService = workspace.Services.GetRequiredService(); - _isImportCompletionExperimentEnabled = experimentationService.IsExperimentEnabled(WellKnownExperimentNames.TypeImportCompletion); - } - - return _isImportCompletionExperimentEnabled == true; - } - public override async Task ProvideCompletionsAsync(CompletionContext completionContext) { var cancellationToken = completionContext.CancellationToken; @@ -64,11 +50,8 @@ public override async Task ProvideCompletionsAsync(CompletionContext completionC var isExpandedCompletion = completionContext.Options.GetOption(CompletionServiceOptions.IsExpandedCompletion); if (!isExpandedCompletion) { - var importCompletionOptionValue = completionContext.Options.GetOption(CompletionOptions.ShowItemsFromUnimportedNamespaces, document.Project.Language); - - // Don't trigger import completion if the option value is "default" and the experiment is disabled for the user. - if (importCompletionOptionValue == false || - (importCompletionOptionValue == null && !IsExperimentEnabled(document.Project.Solution.Workspace))) + var isImportCompletionEnabled = completionContext.Options.GetOption(CompletionOptions.ShowItemsFromUnimportedNamespaces, document.Project.Language); + if (isImportCompletionEnabled == false) { return; } diff --git a/src/VisualStudio/CSharp/Impl/CSharpVSResources.resx b/src/VisualStudio/CSharp/Impl/CSharpVSResources.resx index baebad55c8450..c724eeb4337e4 100644 --- a/src/VisualStudio/CSharp/Impl/CSharpVSResources.resx +++ b/src/VisualStudio/CSharp/Impl/CSharpVSResources.resx @@ -577,7 +577,7 @@ When on multiple lines - Show items from unimported namespaces (experimental) + Show items from unimported namespaces Inside namespace diff --git a/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.cs.xlf b/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.cs.xlf index 63dae0e011360..258e0a67a9a0c 100644 --- a/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.cs.xlf +++ b/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.cs.xlf @@ -118,8 +118,8 @@ - Show items from unimported namespaces (experimental) - Zobrazit položky z neimportovaných oborů názvů (experimentální) + Show items from unimported namespaces + Zobrazit položky z neimportovaných oborů názvů (experimentální) diff --git a/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.de.xlf b/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.de.xlf index 16fe049106877..09da3119d4bcd 100644 --- a/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.de.xlf +++ b/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.de.xlf @@ -118,8 +118,8 @@ - Show items from unimported namespaces (experimental) - Elemente aus nicht importierten Namespaces anzeigen (experimentell) + Show items from unimported namespaces + Elemente aus nicht importierten Namespaces anzeigen (experimentell) diff --git a/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.es.xlf b/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.es.xlf index 9e8d8ac940545..eafbbdaa6ff31 100644 --- a/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.es.xlf +++ b/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.es.xlf @@ -118,8 +118,8 @@ - Show items from unimported namespaces (experimental) - Mostrar elementos de espacios de nombres no importados (experimental) + Show items from unimported namespaces + Mostrar elementos de espacios de nombres no importados (experimental) diff --git a/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.fr.xlf b/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.fr.xlf index e8a904f712ec1..ab7e1765adaad 100644 --- a/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.fr.xlf +++ b/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.fr.xlf @@ -118,8 +118,8 @@ - Show items from unimported namespaces (experimental) - Afficher les éléments des espaces de noms qui ne sont pas importés (expérimental) + Show items from unimported namespaces + Afficher les éléments des espaces de noms qui ne sont pas importés (expérimental) diff --git a/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.it.xlf b/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.it.xlf index be58d03e46eeb..b3b5b54328ca0 100644 --- a/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.it.xlf +++ b/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.it.xlf @@ -118,8 +118,8 @@ - Show items from unimported namespaces (experimental) - Mostra elementi da spazi dei nomi non importati (sperimentale) + Show items from unimported namespaces + Mostra elementi da spazi dei nomi non importati (sperimentale) diff --git a/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.ja.xlf b/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.ja.xlf index 4b0b935e9e16a..fda01b4ff4bd3 100644 --- a/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.ja.xlf +++ b/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.ja.xlf @@ -118,8 +118,8 @@ - Show items from unimported namespaces (experimental) - インポートされていない名前空間の項目を表示する (試験段階) + Show items from unimported namespaces + インポートされていない名前空間の項目を表示する (試験段階) diff --git a/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.ko.xlf b/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.ko.xlf index 4e96246d5f5e5..4b163fba4f4bc 100644 --- a/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.ko.xlf +++ b/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.ko.xlf @@ -118,8 +118,8 @@ - Show items from unimported namespaces (experimental) - 가져오지 않은 네임스페이스의 항목 표시(실험적) + Show items from unimported namespaces + 가져오지 않은 네임스페이스의 항목 표시(실험적) diff --git a/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.pl.xlf b/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.pl.xlf index 7c085f06727a2..ca74132649b93 100644 --- a/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.pl.xlf +++ b/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.pl.xlf @@ -118,8 +118,8 @@ - Show items from unimported namespaces (experimental) - Pokaż elementy z nieimportowanych przestrzeni nazw (eksperymentalne) + Show items from unimported namespaces + Pokaż elementy z nieimportowanych przestrzeni nazw (eksperymentalne) diff --git a/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.pt-BR.xlf b/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.pt-BR.xlf index 990f0b01a69f0..42e3568c5b8b2 100644 --- a/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.pt-BR.xlf +++ b/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.pt-BR.xlf @@ -118,8 +118,8 @@ - Show items from unimported namespaces (experimental) - Mostrar itens de namespaces não importados (experimental) + Show items from unimported namespaces + Mostrar itens de namespaces não importados (experimental) diff --git a/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.ru.xlf b/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.ru.xlf index 82d39d253fe19..cc21141917a53 100644 --- a/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.ru.xlf +++ b/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.ru.xlf @@ -118,8 +118,8 @@ - Show items from unimported namespaces (experimental) - Показать элементы из неимпортированных пространств имен (экспериментальная функция) + Show items from unimported namespaces + Показать элементы из неимпортированных пространств имен (экспериментальная функция) diff --git a/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.tr.xlf b/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.tr.xlf index 6c70f26709939..ac2ebbc5cd3db 100644 --- a/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.tr.xlf +++ b/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.tr.xlf @@ -118,8 +118,8 @@ - Show items from unimported namespaces (experimental) - İçeri aktarılmayan ad alanlarındaki öğeleri göster (deneysel) + Show items from unimported namespaces + İçeri aktarılmayan ad alanlarındaki öğeleri göster (deneysel) diff --git a/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.zh-Hans.xlf b/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.zh-Hans.xlf index 368bf4bb5256f..1d557206e2405 100644 --- a/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.zh-Hans.xlf +++ b/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.zh-Hans.xlf @@ -118,8 +118,8 @@ - Show items from unimported namespaces (experimental) - 显示 unimported 命名空间中的项(实验) + Show items from unimported namespaces + 显示 unimported 命名空间中的项(实验) diff --git a/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.zh-Hant.xlf b/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.zh-Hant.xlf index f45976f52134d..819cf9613246a 100644 --- a/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.zh-Hant.xlf +++ b/src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.zh-Hant.xlf @@ -118,8 +118,8 @@ - Show items from unimported namespaces (experimental) - 顯示來自未匯入命名空間的項目 (實驗性) + Show items from unimported namespaces + 顯示來自未匯入命名空間的項目 (實驗性) diff --git a/src/VisualStudio/Core/Test/Completion/VisualBasicCompletionSnippetNoteTests.vb b/src/VisualStudio/Core/Test/Completion/VisualBasicCompletionSnippetNoteTests.vb index b8e4b438963fe..8a6abf107f85c 100644 --- a/src/VisualStudio/Core/Test/Completion/VisualBasicCompletionSnippetNoteTests.vb +++ b/src/VisualStudio/Core/Test/Completion/VisualBasicCompletionSnippetNoteTests.vb @@ -85,6 +85,10 @@ End Class]]> Dim testSnippetInfoService = DirectCast(state.Workspace.Services.GetLanguageServices(LanguageNames.VisualBasic).GetService(Of ISnippetInfoService)(), TestVisualBasicSnippetInfoService) testSnippetInfoService.SetSnippetShortcuts(snippetShortcuts) + + Dim newOptions = state.Workspace.Options.WithChangedOption(CompletionOptions.ShowItemsFromUnimportedNamespaces, LanguageNames.VisualBasic, False) + state.Workspace.SetOptions(newOptions) + Return state End Function End Class diff --git a/src/VisualStudio/VisualBasic/Impl/BasicVSResources.resx b/src/VisualStudio/VisualBasic/Impl/BasicVSResources.resx index 07c4b5f860abd..7d18560dc8201 100644 --- a/src/VisualStudio/VisualBasic/Impl/BasicVSResources.resx +++ b/src/VisualStudio/VisualBasic/Impl/BasicVSResources.resx @@ -296,7 +296,7 @@ Unused local - Show items from unimported namespaces (experimental) + Show items from unimported namespaces Show remarks in Quick Info diff --git a/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.cs.xlf b/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.cs.xlf index 1f6129aed751e..7bf6f03ecaa7c 100644 --- a/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.cs.xlf +++ b/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.cs.xlf @@ -43,8 +43,8 @@ - Show items from unimported namespaces (experimental) - Zobrazit položky z neimportovaných oborů názvů (experimentální) + Show items from unimported namespaces + Zobrazit položky z neimportovaných oborů názvů (experimentální) diff --git a/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.de.xlf b/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.de.xlf index 667690d4a645b..974479ff2e3fa 100644 --- a/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.de.xlf +++ b/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.de.xlf @@ -43,8 +43,8 @@ - Show items from unimported namespaces (experimental) - Elemente aus nicht importierten Namespaces anzeigen (experimentell) + Show items from unimported namespaces + Elemente aus nicht importierten Namespaces anzeigen (experimentell) diff --git a/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.es.xlf b/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.es.xlf index acc14b99f1c4d..827f3510be822 100644 --- a/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.es.xlf +++ b/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.es.xlf @@ -43,8 +43,8 @@ - Show items from unimported namespaces (experimental) - Mostrar elementos de espacios de nombres no importados (experimental) + Show items from unimported namespaces + Mostrar elementos de espacios de nombres no importados (experimental) diff --git a/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.fr.xlf b/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.fr.xlf index ed7fab4c4784d..e1ad5fb307220 100644 --- a/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.fr.xlf +++ b/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.fr.xlf @@ -43,8 +43,8 @@ - Show items from unimported namespaces (experimental) - Afficher les éléments des espaces de noms qui ne sont pas importés (expérimental) + Show items from unimported namespaces + Afficher les éléments des espaces de noms qui ne sont pas importés (expérimental) diff --git a/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.it.xlf b/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.it.xlf index 21d0ba8162f50..6e9b164f434bf 100644 --- a/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.it.xlf +++ b/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.it.xlf @@ -43,8 +43,8 @@ - Show items from unimported namespaces (experimental) - Mostra elementi da spazi dei nomi non importati (sperimentale) + Show items from unimported namespaces + Mostra elementi da spazi dei nomi non importati (sperimentale) diff --git a/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.ja.xlf b/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.ja.xlf index 108ec1506bf87..7e8ac9cc2d6a5 100644 --- a/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.ja.xlf +++ b/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.ja.xlf @@ -43,8 +43,8 @@ - Show items from unimported namespaces (experimental) - インポートされていない名前空間の項目を表示する (試験段階) + Show items from unimported namespaces + インポートされていない名前空間の項目を表示する (試験段階) diff --git a/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.ko.xlf b/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.ko.xlf index 020cc0f50348a..7d4590d004a66 100644 --- a/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.ko.xlf +++ b/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.ko.xlf @@ -43,8 +43,8 @@ - Show items from unimported namespaces (experimental) - 가져오지 않은 네임스페이스의 항목 표시(실험적) + Show items from unimported namespaces + 가져오지 않은 네임스페이스의 항목 표시(실험적) diff --git a/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.pl.xlf b/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.pl.xlf index d88f61cc0c3e4..b765b6e8d2e98 100644 --- a/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.pl.xlf +++ b/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.pl.xlf @@ -43,8 +43,8 @@ - Show items from unimported namespaces (experimental) - Pokaż elementy z nieimportowanych przestrzeni nazw (eksperymentalne) + Show items from unimported namespaces + Pokaż elementy z nieimportowanych przestrzeni nazw (eksperymentalne) diff --git a/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.pt-BR.xlf b/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.pt-BR.xlf index 5f9c9ab3d508c..960addf12d577 100644 --- a/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.pt-BR.xlf +++ b/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.pt-BR.xlf @@ -43,8 +43,8 @@ - Show items from unimported namespaces (experimental) - Mostrar itens de namespaces não importados (experimental) + Show items from unimported namespaces + Mostrar itens de namespaces não importados (experimental) diff --git a/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.ru.xlf b/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.ru.xlf index 264023ff3473b..8e8b0b649dcbc 100644 --- a/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.ru.xlf +++ b/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.ru.xlf @@ -43,8 +43,8 @@ - Show items from unimported namespaces (experimental) - Показать элементы из неимпортированных пространств имен (экспериментальная функция) + Show items from unimported namespaces + Показать элементы из неимпортированных пространств имен (экспериментальная функция) diff --git a/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.tr.xlf b/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.tr.xlf index d7f131009ac4f..e8bfe3410ed81 100644 --- a/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.tr.xlf +++ b/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.tr.xlf @@ -43,8 +43,8 @@ - Show items from unimported namespaces (experimental) - İçeri aktarılmayan ad alanlarındaki öğeleri göster (deneysel) + Show items from unimported namespaces + İçeri aktarılmayan ad alanlarındaki öğeleri göster (deneysel) diff --git a/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.zh-Hans.xlf b/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.zh-Hans.xlf index 046409923d277..c6be35cc66b79 100644 --- a/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.zh-Hans.xlf +++ b/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.zh-Hans.xlf @@ -43,8 +43,8 @@ - Show items from unimported namespaces (experimental) - 显示 unimported 命名空间中的项(实验) + Show items from unimported namespaces + 显示 unimported 命名空间中的项(实验) diff --git a/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.zh-Hant.xlf b/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.zh-Hant.xlf index af4d772b74dc1..6efdfcd2ac8a9 100644 --- a/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.zh-Hant.xlf +++ b/src/VisualStudio/VisualBasic/Impl/xlf/BasicVSResources.zh-Hant.xlf @@ -43,8 +43,8 @@ - Show items from unimported namespaces (experimental) - 顯示來自未匯入命名空間的項目 (實驗性) + Show items from unimported namespaces + 顯示來自未匯入命名空間的項目 (實驗性) diff --git a/src/Workspaces/Core/Portable/Experiments/IExperimentationService.cs b/src/Workspaces/Core/Portable/Experiments/IExperimentationService.cs index 9fa8fb7e02625..0ef221a88b3e9 100644 --- a/src/Workspaces/Core/Portable/Experiments/IExperimentationService.cs +++ b/src/Workspaces/Core/Portable/Experiments/IExperimentationService.cs @@ -31,7 +31,6 @@ public DefaultExperimentationService() internal static class WellKnownExperimentNames { public const string PartialLoadMode = "Roslyn.PartialLoadMode"; - public const string TypeImportCompletion = "Roslyn.TypeImportCompletion"; public const string TargetTypedCompletionFilter = "Roslyn.TargetTypedCompletionFilter"; public const string TriggerCompletionInArgumentLists = "Roslyn.TriggerCompletionInArgumentLists"; public const string SQLiteInMemoryWriteCache = "Roslyn.SQLiteInMemoryWriteCache";