Datetime variable with servernow() initial value causes NullPointerException (#731)

Issue: 103191

Author: iroqueta

java/client.cfg

@@ -174,7 +174,7 @@ MAX_CURSOR=100
 INITIALIZE_NEW=1
 ISOLATION_LEVEL=CR
 XBASE_TINT=1
-DBMS=sqlserver
+DBMS=sqlite
 UnlimitedRWPool=1
 PoolRWEnabled=1
 RecycleRW=1

java/src/main/java/com/genexus/GXutil.java

@@ -8,6 +8,7 @@
 import java.util.*;
 
 import com.genexus.common.interfaces.SpecificImplementation;
+import com.genexus.db.DataStoreProvider;
 import com.genexus.internet.HttpContext;
 import com.genexus.internet.StringCollection;
 import com.genexus.platform.INativeFunctions;
@@ -974,16 +975,22 @@ public static Date serverNow(ModelContext context, int handle, String dataSource
 
 	public static Date serverNow(ModelContext context, int handle, com.genexus.db.IDataStoreProvider dataStore)
 	{
+		if (dataStore == null)
+			dataStore = new DataStoreProvider(context, handle);
 		return serverNow( context, handle, dataStore, false);
 	}	
 
 	public static Date serverNowMs(ModelContext context, int handle, com.genexus.db.IDataStoreProvider dataStore)
 	{
+		if (dataStore == null)
+			dataStore = new DataStoreProvider(context, handle);
 		return serverNow( context, handle, dataStore, true);
 	}	
 
 	public static Date serverNow(ModelContext context, int handle, com.genexus.db.IDataStoreProvider dataStore, boolean millisecond)
 	{
+		if (dataStore == null)
+			dataStore = new DataStoreProvider(context, handle);
 		return SpecificImplementation.GXutil.serverNow(context, handle, dataStore, millisecond);
 	}
 

java/src/main/java/com/genexus/db/DataStoreProvider.java

@@ -37,6 +37,11 @@ public class DataStoreProvider extends DataStoreProviderBase implements
 
 	private static AtomicBoolean firstTime = new AtomicBoolean(true);
 
+	public DataStoreProvider(ModelContext context, int remoteHandle)
+	{
+		super(context, remoteHandle);
+	}
+
 	public DataStoreProvider(ModelContext context, int remoteHandle, ILocalDataStoreHelper helper, Object[] buffers)
 	{
 		super(context, remoteHandle);

java/src/main/java/com/genexus/db/DataStoreProviderBase.java

@@ -32,13 +32,19 @@ protected DataStoreProviderBase(ModelContext context, int remoteHandle)
 
 	public GXConnection getConnection() throws SQLException
 	{
+		if (getHelper() == null)
+			return getConnection("DEFAULT", false);
+
 		return getConnection(getHelper().getDataStoreName(), getHelper().needsReadOnlyConnection());
 	}
 	protected GXConnection getConnection(String dataStoreName, boolean needsReadOnlyConnection) throws SQLException
 	{
 		if	(connectionProvider == null)
 		{
-			connectionProvider = getHelper().getConnectionProvider();
+			if (getHelper() == null)
+				connectionProvider = new DefaultConnectionProvider();
+			else
+				connectionProvider = getHelper().getConnectionProvider();
 		}
 
 		con = (GXConnection) connectionProvider.getConnection(context, remoteHandle, dataStoreName, needsReadOnlyConnection, true);

java/src/main/java/com/genexus/db/driver/GXDBMSsqlite.java

@@ -1,6 +1,8 @@
 package com.genexus.db.driver;
 
 import java.sql.*;
+import java.text.ParseException;
+import java.text.SimpleDateFormat;
 import java.util.Date;
 
 import com.genexus.CommonUtil;
@@ -120,13 +122,24 @@ public void onConnection(GXConnection con) throws SQLException
 
 	public java.util.Date serverDateTime(GXConnection con) throws SQLException
 	{
-		ResultSet rslt = con.getStatement("_ServerDT_", "SELECT GETDATE()", false).executeQuery();
+		ResultSet rslt = con.getStatement("_ServerDT_", "SELECT datetime('now')", false).executeQuery();
 
 		rslt.next();
-		Date value = rslt.getTimestamp(1);
+		String value = rslt.getString(1);
 		rslt.close();
 
-		return value;
+		SimpleDateFormat sdf = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss");
+		Date dateValue;
+		try
+		{
+			dateValue = sdf.parse(value);
+		}
+		catch (ParseException e)
+		{
+			dateValue = nullDate();
+		}
+
+		return dateValue;
 	}
 
 	public String serverVersion(GXConnection con) throws SQLException

java/src/test/java/com/genexus/db/driver/TestServerNowNullProvider.java

@@ -0,0 +1,41 @@
+package com.genexus.db.driver;
+
+import com.genexus.Application;
+import com.genexus.ClientContext;
+import com.genexus.GXObjectHelper;
+import com.genexus.GXutil;
+import com.genexus.db.IDataStoreProvider;
+import com.genexus.db.UserInformation;
+import com.genexus.sampleapp.GXcfg;
+import com.genexus.specific.java.Connect;
+import org.junit.Assert;
+import org.junit.Test;
+
+import java.util.Calendar;
+
+public class TestServerNowNullProvider {
+
+	@Test
+	public void testGetProviderNormalizedUrl() {
+		Connect.init();
+		Application.init(GXcfg.class);
+		int  remoteHandle = ((UserInformation) GXObjectHelper.getUserInformation(ClientContext.getModelContext(), -1)).getHandle();
+
+		java.util.Date serverDate = GXutil.serverNow(ClientContext.getModelContext(), remoteHandle, (IDataStoreProvider)null) ;
+		Calendar calendar = Calendar.getInstance();
+		calendar.setTime(serverDate);
+		int century = getCentury(calendar);
+		Assert.assertEquals(century, 21);
+
+		serverDate = GXutil.serverNowMs(ClientContext.getModelContext(), remoteHandle, null) ;
+		calendar.setTime(serverDate);
+		century = getCentury(calendar);
+		Assert.assertEquals(century, 21);
+
+	}
+
+	private int getCentury(Calendar calendar) {
+		int year = calendar.get(Calendar.YEAR) - 1;
+		return  (year / 100) + 1;
+	}
+}