Hero: 2.0.0 Dimming 0/100 error

[Mil1]

Hello,

Is very nice starter theme i love use it !

In the Hero block the dimming to 0 no work, I think it's due to a mathematical error: <?php echo esc_attr($data['dimming_opacity'] / 100); ?>

But not, is just the if (isset($f['dimming']) && !empty($f['dimming'])) { of 0 return default value of $placeholders

Thank you

[TeemuSuoranta]

Hi!

This is true. I should add check for division by 0 situation as PHP might go full fatal error with that one.

[TeemuSuoranta]

Seems like there was another bug that was keeping the division by 0 from appearing by default as having 0 dimming resulted using the default dimming (20) instead of user selected 0. This is now fixed in dev branch and I'll close this issue when it is merged.