-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up current development cycle with bypasses for some time-consuming tasks #126
Comments
@pgaudet While I've added this as a TODO in the current sprint, it will likely be something that is incidentally done as part of other development and is a "freebie". Please let me know if you have concerns about its categorization. |
Hi @kltm Thanks, Pascale |
This would have no effect on |
I'm starting a branch and going to start some initial work here. Branch is master_speedup_issue-126. |
|
Here's the branch so far: https://github.com/geneontology/pipeline/tree/issue-126-master_speedup
I check if we have REUSE_PREVIOUS_WORK_P set and if we're snapshot or release, in which case we bail. Then if we do have it set and we didn't bail, then we set the noctua branch to the smaller subset branch. I have an unused variable in there at the moment that we can delete to set the standard noctua branch as well (if we wanted to switch back?? Not sure if we need that ultimately). TODO: We will have to make a Makefile change I think in order for the noctua-models change to propagate into the Makefile step where we clone the repo ourselves. Perhaps that route of getting the noctua-models should be investigated in the Makefile at some point? But as it is the Makefile will only grab master noctua-models, and so will load everything into the blazegraph. If we want a faster run, we should make sure to get the small subset loaded. |
Discussed with @dougli1sqrd on current branch work--looking good. TODO: generalized (single target branch) for noctua-models, ontology copyover, (bonus) noctua-models target branch into Makefile. |
geneontology/go-site#1183 For noctua models cloning in go-site Makefile |
#129 is the final set of things on the list above. We should run a test of this. |
@kltm I can make changes to the |
@dougli1sqrd Good to test and prep. |
I think this one has timed out. |
The
master
(main development) build currently takes almost seven hours to complete--basically the length of time a full run used to take sometime last year. This severely slows down the development and testing cycle. We have tricks that that we'd like to formalize that we've used on branches to speed things up.These options would be turned on/off with a
REUSE_PREVIOUS_WORK_P = 'TRUE'
. In additions to these, this would be also haverelease
orsnapshot
An experiment indicated that we could trim 3-4hrs off of
master
build time, with an aggressive data trimming getting us down to about 1.5hr total time.As we're already doing things like this as part of our normal development, this would just be to systematize these tricks. The next time we do something like this, we'd like to add them back in to
master
.Tagging @dougli1sqrd @kltm
The text was updated successfully, but these errors were encountered: