Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter MF unknowns with non-ND evidence out of annotation preview/GPAD #463

Closed
krchristie opened this issue Jul 13, 2017 · 5 comments
Closed
Milestone

Comments

@krchristie
Copy link

Today at MGI's GO group meeting, we were discussing the presence of the unknown, i.e. root level, MF annotations in the Annotation Preview.

We were wondering if it would be possible to filter out the root level MF annotations with non-ND evidence codes, i.e. the ones made from annotons where the function involved in the process or localized to a component is not known.

  • Making these root MF annotations with non-ND evidence codes is against the GO guidelines for using root level annotations specifically indicate when a curator has looked and has been unable to find information for a specific GO aspect: http://www.geneontology.org/page/nd-no-biological-data-available
  • Having all these extra MF annotations to the root makes it harder to check that the model is producing the annotations you do want, for example see the model indicated below where I want to make 11 CC annotations and 0 MF annotations:

ID: gomodel:595a9ee700000731
Name: PMID:27914912-KRC Foxj1 targets

Note that this would only apply to root level MF annotations with non-ND codes. We would still want to be able to make root level annotations WITH the ND code as discussed in this ticket: #320

@edwong57
Copy link

SGD curators would love this too. In our training exercises, we have been hacking this by removing the 'molecular_function' from the annoton so that it doesn't show up in the GPAD/annotation preview, but it isn't ideal.

@kltm kltm changed the title filter MF unknowns with non-ND evidence out of annotation preview/GPAD? Filter MF unknowns with non-ND evidence out of annotation preview/GPAD Aug 7, 2017
@kltm kltm added this to the wishlist milestone Aug 7, 2017
@balhoff
Copy link
Member

balhoff commented Aug 9, 2017

This should be live after the next Minerva restart.

@balhoff
Copy link
Member

balhoff commented Aug 17, 2017

@krchristie can you check that this works as you expect now? Thanks.

@kltm
Copy link
Member

kltm commented Aug 28, 2017

Looking for feedback from @krchristie (or @edwong57 ) before closing out.

@krchristie
Copy link
Author

Apologies so slow to get to this, a combination of several different trips with an email rule that isn't specific enough to flag my attention for Noctua tickets I'm mentioned in.

For the model I listed above when I opened the ticket, the filtering out of MF unknowns is great, leaving only the component annotations I want.

I also tested that root MF annotations do not get filtered out using this model:

ID: gomodel:59a105b300000000
Name: TEST: unknown with ND

Both look good to me.

thanks!

@kltm kltm closed this as completed Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants