Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for handling negations in ShEx validation #433

Merged
merged 2 commits into from
Nov 10, 2021
Merged

Fixes for handling negations in ShEx validation #433

merged 2 commits into from
Nov 10, 2021

Conversation

balhoff
Copy link
Member

@balhoff balhoff commented Nov 10, 2021

Fixes #399.

@balhoff
Correctly find superclasses for negated types during ShEx validation.…
a452b1a 
… Fix null pointer exception when reporting negated types during ShEx validation.
dustine32
dustine32 approved these changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@dustine32 dustine32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@balhoff Thank you, this was super fast!

I just tested this branch on the three example models in #399 and no NPE error!

I'd say this is good to merge whenever you like.

@balhoff balhoff merged commit 8192ba1 into dev Nov 10, 2021
@balhoff balhoff deleted the issue-399 branch November 10, 2021 21:02
@balhoff balhoff mentioned this pull request Nov 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustine32 dustine32 dustine32 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@balhoff @dustine32