Updating production Minerva #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ator this allows the code to continue if this error is encountered. Would be better to fix the bug but not sure its worth the effort unless this gets used.
@kltm could you please deploy this on dev so that we can check everything is ok before doing a second PR for the ART workbench ? Thanks
…to align number of results returned with the number of matching models.
GROUP BY only model id.
Fix mismatch in date variable so that ordering works.
Close output streams when dumping files.
add located_in and is_active_in to allowed list of relations fixes #385
|
@balhoff Odd that some tests were not successful, but I guess that was a known issue, correct? |
Not known to me! |
|
Ha--neat! I guess we'll see what happens. It seems to be passing now anyways. Huh. |
|
And cheers for random code outcomes ! I have not looked at the error, could it be a network issue ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kltm I believe this is what is powering the dev server. This PR will be the one for ART production as tested by @vanaukenk and @ukemi @lpalbou