-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add located_in and is_active_in to allowed list of relations fixes #385 #384
Conversation
@balhoff - reopened as PR on dev instead of master. |
@sierra-moxon Yeah, I bet this would work. Thanks! |
@vanaukenk @ukemi could you please also sign off on this? Asking because adding these has been pending for quite a long time and I'm not sure what has been holding it up, besides inertia. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good technically but I asked Kimberly and David to approve.
thanks so much @ukemi and @vanaukenk for taking a look. As per @dustine32's great debugging, I hope this issue will help bring in the remaining noctua annotations to ZFIN (the testing revealed that they are getting left behind on roundtrip from ZFIN->noctua(one time import)->ZFIN. :) |
@balhoff do we have the right property chains in place? enables o occurs_in -> is_active_in ? I think we need that, if not for the imports then for hand-curated models. You diff looks good to me. |
Thanks @balhoff |
|
No description provided.