Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add located_in and is_active_in to allowed list of relations fixes #385 #384

Merged
merged 2 commits into from
May 6, 2021

Conversation

sierra-moxon
Copy link
Member

No description provided.

@sierra-moxon
Copy link
Member Author

@balhoff - reopened as PR on dev instead of master.

@sierra-moxon sierra-moxon changed the title add located_in and is_active_in to allowed list of relations add located_in and is_active_in to allowed list of relations fixes #385 May 4, 2021
@dustine32
Copy link
Contributor

@sierra-moxon Yeah, I bet this would work. Thanks!

@dustine32 dustine32 requested a review from balhoff May 4, 2021 16:19
@balhoff balhoff requested review from ukemi and vanaukenk May 4, 2021 16:47
@balhoff
Copy link
Member

balhoff commented May 4, 2021

@vanaukenk @ukemi could you please also sign off on this? Asking because adding these has been pending for quite a long time and I'm not sure what has been holding it up, besides inertia.

Copy link
Member

@balhoff balhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good technically but I asked Kimberly and David to approve.

@sierra-moxon
Copy link
Member Author

thanks so much @ukemi and @vanaukenk for taking a look. As per @dustine32's great debugging, I hope this issue will help bring in the remaining noctua annotations to ZFIN (the testing revealed that they are getting left behind on roundtrip from ZFIN->noctua(one time import)->ZFIN. :)

@ukemi
Copy link

ukemi commented May 5, 2021

@balhoff do we have the right property chains in place? enables o occurs_in -> is_active_in ? I think we need that, if not for the imports then for hand-curated models. You diff looks good to me.

@vanaukenk
Copy link

Thanks @balhoff
I think I just have the same question as David about the property chain for the GPAD exports: enables o occurs_in -> is_active_in

@balhoff
Copy link
Member

balhoff commented May 6, 2021

  • enables o occurs_in -> is_active_in => this is in RO
  • There are some other axiom changes proposed in enables_o_occurs_in -> is_active_in ? #179 that we should review. I don't think that should hold this change up.

@balhoff balhoff merged commit fbcfbf9 into geneontology:dev May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants