Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ART API for stored model #365

Merged
merged 4 commits into from
Jan 8, 2021
Merged

Added ART API for stored model #365

merged 4 commits into from
Jan 8, 2021

Conversation

tmushayahama
Copy link
Contributor

@tmushayahama tmushayahama commented Dec 18, 2020

@lpalbou and I worked on making temporary stored model api until diff as per this comment #364

This is to show sample code. This is a working art api to get the stored model

The approach of separate API doesn't cause any side effect as it is readonly and easy to extend without hustles. It uses the same concept as searchAPI with jetty. Take a look how it is decoupled with m3Batch

to get the store endpoint is

from minerva http://localhost:6800/search/stored?id=gomodel:5fdc2fda00000000
from barista http://localhost:3400/search/stored?id=gomodel:5fdc2fda00000000

reason for search endpoint is temporary testing as barista only allows search proxy

tagging @lpalbou @balhoff @kltm

@tmushayahama tmushayahama changed the title Added ART api sample code (no tests yet, dont pull) Added ART for stored model Jan 6, 2021
@tmushayahama
Copy link
Contributor Author

I have added the initial tests and ready for review and merge.

tagging @balhoff @kltm @lpalbou

@tmushayahama
Copy link
Contributor Author

As discussed, I have fixed the equal and not using the JsonModel equal function @balhoff @lpalbou . Thank you all for going over this. The call really helped.

@lpalbou lpalbou merged commit 43698c6 into dev Jan 8, 2021
@tmushayahama tmushayahama changed the title Added ART for stored model Added ART API for stored model Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants