Eliminate imports #346
Merged
Eliminate imports #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoreMolecularModelManager.removeDeadAnnotationsAndImports takes out imports and tje json_model annotation property. This plus the CoreMolecularModelManager.fixBrokenObjectPropertiesAndAxioms for handling loader problems results in go-cams with no import statements and with all of their object properties properly declared.
|
@kltm hold up. Just detected a problem with new models. DO NOT MERGE yet. |
|
@kltm when... |
|
okay seems to be good. lets go for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #345
But we need to stop the server, run it on all the models in the repo, and restart. Running the cleaner e.g. :
minerva_cli.sh --clean-gocams -i /usr/src/GitHub/noctua-models/models/ -o /usr/src/GitHub/noctua-models/models/cleaned_dir/
Or I can run it and commit the changes to master.
@kltm ??