Conversion to neo lite and golr #260 #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 13, 2019 10:14
Should not be possible when launching minerva normally.
balhoff
reviewed
Nov 20, 2019
| List<GolrOntologyClassDocument> ontologyEntities = ontologyClient.getGolrOntologyCls(curie); | ||
| if (ontologyEntities != null && !ontologyEntities.isEmpty()) { | ||
| result = new ArrayList<ExternalLookupService.LookupEntry>(ontologyEntities.size()); | ||
| for(GolrOntologyClassDocument doc : ontologyEntities) { | ||
| result.add(new LookupEntry(id, doc.annotation_class_label, "ontology_class", null)); | ||
| result.add(new LookupEntry(id, doc.annotation_class_label, "ontology_class", doc.only_in_taxon, doc.isa_partof_closure)); |
There was a problem hiding this comment.
@goodb shouldn't this be only isa_closure, not isa_partof_closure?
balhoff
reviewed
Nov 20, 2019
| @@ -58,7 +58,7 @@ protected MonarchExternalLookupService(String golrUrl, RetrieveGolrOntologyClass | |||
| if (entities != null && !entities.isEmpty()) { | |||
| result = new ArrayList<ExternalLookupService.LookupEntry>(entities.size()); | |||
| for(GolrOntologyClassDocument doc : entities) { | |||
| result.add(new LookupEntry(id, doc.annotation_class_label, "ontology_class", null)); | |||
| result.add(new LookupEntry(id, doc.annotation_class_label, "ontology_class", null, doc.isa_partof_closure)); | |||
There was a problem hiding this comment.
@goodb shouldn't this be only isa_closure, not isa_partof_closure? (same question as in other file)
|
Yes, I think it should be just isa_closure. The OWLTools class GolrOntologyClassDocument that minerva was using doesn't have just the isa_closure element. I think for what we are doing it won't really matter, but you are right. I will go ahead and add it in to my stolen instance. Hopefully GOLR supports that query properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.