Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toast position configureable #306

Closed
1 of 2 tasks
hoetmaaiers opened this issue Jul 1, 2020 · 6 comments
Closed
1 of 2 tasks

Toast position configureable #306

hoetmaaiers opened this issue Jul 1, 2020 · 6 comments
Assignees

Comments

@hoetmaaiers
Copy link

Feature request 🚀

  • I will create Pull Request
  • It's just a suggestion

Expected

I would like the toast to be configurable in one of 4 screen corners. Is this on purpose not on option or just room for improvement?

@unix unix self-assigned this Jul 1, 2020
@unix
Copy link
Member

unix commented Jul 1, 2020

This is really something that can be improved, in fact, I considered and tried this idea when I created Toast component, and it's not hard to do this in code. But I finally removed this feature (placement), because the animation effect is not satisfactory.

For example, the Toast component at the bottom are stacked together, they gradually move up and disappear, and there is a hierarchical relationship of the Z-axis, but if they're at the top, the opposite Z-axis relationship looks strange. (Note that all components need to be expanded when the mouse move-in.) In order to ensure the rationality of the behavior, the current component does not move when the mouse moves in, while other components expand in another direction, this means that the last displayed component must be at the top. The animation of component Toast looks good, but it doesn't work well in the opposite position.

@unix
Copy link
Member

unix commented Jul 1, 2020

Remove stacked effects makes them look more reasonable (in placement case), but it's not a good idea either, so I finally removed placement.

@hoetmaaiers
Copy link
Author

I do think the stacked effects are a good thing. The animations should be tailored to the position then I think.

Is it possible to render the toasts in a specific container element? This way, the position could be tweaked.

@unix
Copy link
Member

unix commented Jul 1, 2020

Yes, it's in a container right now.
I mean the animation is form top to bottom, and stacking is also from top to bottom, which is very strange. Well, it's hard to explain, but what I'm saying is that this feature was removed for no technical reason.

@unix
Copy link
Member

unix commented Jul 4, 2020

Hi, @hoetmaaiers , I create a new issue to extend your idea, this issue has been moved #315 .

@hoetmaaiers
Copy link
Author

Thanks for digging further into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants