Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a variable docker_apt_filename to control apt repository filename #101

Closed
julien-lecomte opened this issue Dec 1, 2018 · 5 comments
Closed
Labels

Comments

@julien-lecomte
Copy link

Feature Request:

Add a variable docker_apt_filename to control apt repository filename. Default to ansible apt_repository default's (https://docs.ansible.com/ansible/2.6/modules/apt_repository_module.html)

@geerlingguy
Copy link
Owner

Can you give a little more detail as to why you would like more control over the filename? I haven't had to do this before, but if it's a common need I would be okay supporting it.

@julien-lecomte
Copy link
Author

Is OCD a valid reason? ;-)

My reason is that I have legacy scripts that use the file names to activate / deactive sources and packages and other actions based on filename. ie: On the buster system I have under my hand right now I have debian-buster.list, debian-buster-updates.list, debian-buster-security.list, and docker-ce.list; each with only one line.

I don't know how common this is, but at worst it adds an optional functionality without breaking existing behavior.
I'd reason that if it was added to ansible in 2.1, there must have been a need.

@julien-lecomte
Copy link
Author

Hi
May I ask for an update on this? Most notably, will you accept to merge the associated MR?
Thanks,
Julien

@stale
Copy link

stale bot commented Mar 6, 2020

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

@stale stale bot added the stale label Mar 6, 2020
@stale
Copy link

stale bot commented Apr 5, 2020

This issue has been closed due to inactivity. If you feel this is in error, please reopen the issue or file a new issue with the relevant details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants