Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep the camelCase method to mirror GEE javascript map functions #1772

Closed
12rambau opened this issue Oct 13, 2023 · 1 comment · Fixed by #1777
Closed

keep the camelCase method to mirror GEE javascript map functions #1772

12rambau opened this issue Oct 13, 2023 · 1 comment · Fixed by #1777
Assignees

Comments

@12rambau
Copy link
Member

I asked this question during the breakout session of Geo4Good, If I understand correctly you are planning on dropping methods that were mirroring GEE javascript ones.

Also I completely understand that respecting the Python convention is making the geempa package more consistent, I wanted to highligh 2 advantages:

  • if you are coming from the code editor you know by design that this function is perfectly mimicking the behaviour you would get in the javascript interface
  • It gives Python users an insight: this is a earthengine-API call which is very relevant for Commercial users of the lib. That's the reasoning I'm following to refactor geeo_tools.

I think keeping them in painless as it's a 1 liner at the end of the class:

class Map: 
    # ...
    addLayer = self.add_ee_layer

_Originally posted by @12rambau in https://github.com/gee-community/geemap/discussions/1770_
@12rambau 12rambau changed the title I asked this question during the breakout session of Geo4Good, If I understand correctly you are planning on dropping methods that were mirroring GEE javascript ones. keep the camelCase method to mirror GEE javascript map functions Oct 13, 2023
@12rambau
Copy link
Member Author

@giswqs could you assigned the issue to me ? (I won't be coding before monday)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant