Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summer 2024 refactoring #92

Open
andrea-bistacchi opened this issue Sep 6, 2024 · 2 comments
Open

Summer 2024 refactoring #92

andrea-bistacchi opened this issue Sep 6, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request high priority Important fix/feature/issue

Comments

@andrea-bistacchi
Copy link
Collaborator

I summarize here what we have done and what we still need to do to complete the refactoring in many key parts of the project.

The tree of branches is available in the network graph.

From this it is apparent that windows_refactoring and class_refactoring are basically the same branch that at some point changed its name. This is simple and good!

Another branch called convert_2_x_section was opened with the purpose of converting objects geometrically aligned along a cross-section, but not assigned to a XSection in the project, to a new XSection. We can consider this as an unsuccseful attempt, and also not very useful, and forget about it!

While developing windows_refactoring and class_refactoring some stuff has been changed in the master branch, namely some stuff in the README file, and the function used to import many cross-sections at ounce from Gocad ASCII format (in the gocad2vtk module). The README file is obviously not a problem, so we just wave to ensure that the changes related to importing Gocad ASCII cross-sections are properly ported into the class_refactoring branch, then the latter could be merged to become the new master.

Some of the updates in the general refactoring (implemented or still to be implemented) are discussed in #88, #82, #90, #91, #89, #83, #87, #86, #81, #77, #15, #37, #65.

@andrea-bistacchi andrea-bistacchi added enhancement New feature or request high priority Important fix/feature/issue labels Sep 6, 2024
@andrea-bistacchi
Copy link
Collaborator Author

Also @gbene commit of 13/6/2024 on the master branch about "quick fix for well importing" is already included also in class_refactoring.

@andrea-bistacchi
Copy link
Collaborator Author

It looks like that in commit 55a04eb I was able to add to the class_refactoring branch all (or the most important) updates on the README file and the function used to import many cross-sections at once from Gocad ASCII format (in the gocad2vtk module).

This should be tested and then the class_refactoring branch could become the new master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high priority Important fix/feature/issue
Projects
None yet
Development

No branches or pull requests

3 participants