Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mortality time dependencies should be checked #73

Open
khufkens opened this issue Apr 4, 2022 · 3 comments
Open

Mortality time dependencies should be checked #73

khufkens opened this issue Apr 4, 2022 · 3 comments
Assignees

Comments

@khufkens
Copy link
Contributor

khufkens commented Apr 4, 2022

Comparing BiomeE-Allocation, from where we've copied the code, shows that the mortality formulation was changed quite a bit. In particular, the factor deltat/seconds_per_year has been removed? @lauramarques

@lauramarques
Copy link
Collaborator

Tracking back the commits this was changed together with the deathrate +0.01 (see here)

@stineb
Copy link
Collaborator

stineb commented Apr 5, 2022

@lauramarques Is it correct to remove that factor? Isn't that problematic when using a dynamic time stepping, defined by the model forcing?

@stineb
Copy link
Collaborator

stineb commented May 17, 2024

@lauramarques Can we close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants