Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider to take in account reply message in outgoing limits #3784

Closed
grishasobol opened this issue Mar 5, 2024 · 2 comments
Closed

consider to take in account reply message in outgoing limits #3784

grishasobol opened this issue Mar 5, 2024 · 2 comments
Labels
C2-refactoring Refactoring proposal

Comments

@grishasobol
Copy link
Member

grishasobol commented Mar 5, 2024 •
edited
Loading

File Location(s)

core/src/message/context.rs

Proposal

Currently both constants OutgoingLimit and OutgoingBytesLimit are limits that take in account only outgoing messages without reply. @breathx proposed to expand limits responsibility to reply messages also.
So, need to investigate whether it's suitable proposal. And if it is then make a refactoring in reply_push reply_commit and reply_push_input which takes in account this limits.
@grishasobol grishasobol added the C2-refactoring Refactoring proposal label Mar 5, 2024
@grishasobol
Copy link
Member Author

Issue appears dues to discussion in #3743

@grishasobol grishasobol changed the title consider to take in account reply message in OutgoingLimit and OutgoingBytesLimit consider to take in account reply message in outgoing limits Mar 5, 2024
@grishasobol grishasobol mentioned this issue Mar 5, 2024
Merged
@grishasobol
Copy link
Member Author

stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C2-refactoring Refactoring proposal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@grishasobol