From 053f0c21e8bcbfd50f3c42b23467ed640a6e1d03 Mon Sep 17 00:00:00 2001 From: Joaquin Matres <4514346+joamatab@users.noreply.github.com> Date: Fri, 17 May 2024 10:59:41 -0400 Subject: [PATCH 1/2] better values --- cspdk/si220/cells.py | 6 +++--- cspdk/si220/samples/circuit_simulations_sc.py | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/cspdk/si220/cells.py b/cspdk/si220/cells.py index e826603..2251e7a 100644 --- a/cspdk/si220/cells.py +++ b/cspdk/si220/cells.py @@ -1038,6 +1038,7 @@ def mzi_sc( length_y: float = 2.0, length_x: float = 0.1, add_electrical_ports_bot: bool = True, + cross_section: CrossSectionSpec = "xs_sc", **kwargs, ) -> gf.Component: """A Mach-Zehnder Interferometer (MZI) in strip, c-band. @@ -1051,8 +1052,6 @@ def mzi_sc( Returns: gf.Component: the component """ - if "cross_section" not in kwargs: - kwargs["cross_section"] = "xs_sc" return _mzi( delta_length=delta_length, length_y=length_y, @@ -1062,6 +1061,7 @@ def mzi_sc( bend=bend_sc, combiner=mmi1x2_sc, splitter=mmi1x2_sc, + cross_section=cross_section, **kwargs, ) @@ -1478,7 +1478,7 @@ def crossing_sc() -> gf.Component: if __name__ == "__main__": - c = die_sc() + c = mzi_sc() # c = crossing_sc() c.show() # for name, func in list(globals().items()): diff --git a/cspdk/si220/samples/circuit_simulations_sc.py b/cspdk/si220/samples/circuit_simulations_sc.py index 4f32dbc..f00bd61 100644 --- a/cspdk/si220/samples/circuit_simulations_sc.py +++ b/cspdk/si220/samples/circuit_simulations_sc.py @@ -5,7 +5,7 @@ from cspdk.si220 import PDK, cells if __name__ == "__main__": - c = cells.mzi_sc(delta_length=100) + c = cells.mzi_sc(delta_length=50) c.show() c.plot_netlist() netlist = c.get_netlist() From 057ab93d7a22c67804cd181d1c250592c516b5c0 Mon Sep 17 00:00:00 2001 From: Joaquin Matres <4514346+joamatab@users.noreply.github.com> Date: Fri, 17 May 2024 12:50:36 -0400 Subject: [PATCH 2/2] update readme --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index c4f7041..61852c1 100644 --- a/README.md +++ b/README.md @@ -1,8 +1,8 @@ -# CornerStone PDK 0.8.2 +# CORNERSTONE PDK 0.8.2 ![](https://i.imgur.com/V5Ukc6j.png) -[CornerStone](https://www.cornerstone.sotonfab.co.uk/) Photonics PDK. +[CORNERSTONE](https://www.cornerstone.sotonfab.co.uk/) Photonics PDK. ## Installation