Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix images displaying wider than card #26

Merged
merged 2 commits into from
Nov 6, 2015

Conversation

thunsaker
Copy link
Contributor

Fixes #25

Added example to "Google Developers Group" post to show issue.

@@ -30,3 +30,7 @@
}

}

p img {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, @thunsaker can you move this to .post-content class?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing.

Does it still need to be wrapped by the <p> tag? Might be redundant at this point, after moving it into the appropriate selector.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nop, just

.post-content { img { width: 100% } }

because in this mode no matter if they are inside a <p> or a <li> or whatever, all the image should adjust to the content width 😄 .

@oscarmcm oscarmcm added this to the jekyll-mdl 2.0 version milestone Nov 2, 2015
@oscarmcm oscarmcm self-assigned this Nov 2, 2015
oscarmcm added a commit that referenced this pull request Nov 6, 2015
🐛 Fix images displaying wider than card
@oscarmcm oscarmcm merged commit db4487a into gdgmanagua:master Nov 6, 2015
@oscarmcm
Copy link
Member

oscarmcm commented Nov 6, 2015

@thunsaker awesome 👍 thanks for your contribution 😄

@thunsaker thunsaker deleted the feature/img-width branch November 6, 2015 15:22
oscarmcm added a commit that referenced this pull request Nov 16, 2015
🐛 Fix images displaying wider than card
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants