Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dataverse:unstable increased the version to 6.3 #195

Closed
5 tasks done
shoeffner opened this issue Jul 18, 2024 · 0 comments · Fixed by #197
Closed
5 tasks done

dataverse:unstable increased the version to 6.3 #195

shoeffner opened this issue Jul 18, 2024 · 0 comments · Fixed by #197
Labels
status:incoming Newly created issue to be forwarded type:bug Something isn't working

Comments

@shoeffner
Copy link
Collaborator

shoeffner commented Jul 18, 2024

Prerequisites

  • Are you running the expected version of pyDataverse? (check via pip freeze).

main branch

Bug report

The :unstable docker image now ships dataverse 6.3, but DV_VERSION in the docker-compose-test-all.yml is pinned to 6.2, causing several tests to fail.

1. Describe your environment

  • OS: Ubuntu (I think... in the container)
  • pyDataverse: main branch
  • Python: 3.11 (in the container)
  • Dataverse: 6.3 (!)

2. Actual behaviour:

Some tests fail (here one example):

_______________________ TestApiToken.test_token_missing ________________________

self = <tests.api.test_api.TestApiToken object at 0xffff8b262fd0>

    def test_token_missing(self):
        BASE_URL = os.getenv("BASE_URL").rstrip("/")
        api = NativeApi(BASE_URL)
        resp = api.get_info_version()
>       assert resp.json()["data"]["version"] == os.getenv("DV_VERSION")
E       AssertionError: assert '6.3' == '6.2'
E         
E         - 6.2
E         + 6.3

tests/api/test_api.py:75: AssertionError

3. Expected behaviour:

The tests pass.

4. Steps to reproduce

  1. sh run-tests.sh.

❌ Unit tests failed. Printing logs...

5. Possible solution

  • Update DV_VERSION in docker-compose-test-all.yml to 6.3.
  • Do not use :unstable but pin to a specific image version. Since Dataverse only tags two versions, I guess a hash might work instead.
  • Ask if Dataverse's docker images can be tagged with the versions, so that we could even test against different versions easily, for example to handle different API changes.

I will provide a PR to increase the version to 6.3, as described in the first variant. I don't think the second is feasible right now, but I think it might be worth exploring the third option, though I really don't know what the status of the Dataverse development in general is on that matter.

@shoeffner shoeffner added status:incoming Newly created issue to be forwarded type:bug Something isn't working labels Jul 18, 2024
@shoeffner shoeffner mentioned this issue Jul 18, 2024
26 tasks
@shoeffner shoeffner mentioned this issue Jul 18, 2024
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:incoming Newly created issue to be forwarded type:bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant