New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feedback from review #11

Closed

pdurbin opened this issue Dec 21, 2022 · 1 comment · Fixed by #13

Member

pdurbin commented Dec 21, 2022 •

edited

Loading

I'm reviewing the code on the Dataverse side at IQSS/dataverse#9096 and plan to use this issue to list bugs and typos I find:

typo: "aftterwards"
"Help/Tutorial" links to https://github.com/gdcc/dvwebloader/wiki/DVWebloader---a-bulk-file-uploader-for-Dataverse which prompts the user to create a new wiki page.
green "upload complete" when it actually failed (see screenshot below)
API token shown by console.log
...

pdurbin mentioned this issue

IQSS/9095-dvwebloader integration IQSS/dataverse#9096

Merged

Member

qqmyers commented Dec 22, 2022

Fixed the doc-related issues. Will leave open for the code changes.

qqmyers mentioned this issue

Fixity and a11y #13

Merged

qqmyers closed this as completed in #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment