Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository information for Maven ecosystem #29

Closed
ctron opened this issue May 31, 2024 · 2 comments · Fixed by #30
Closed

Repository information for Maven ecosystem #29

ctron opened this issue May 31, 2024 · 2 comments · Fixed by #30

Comments

@ctron
Copy link
Contributor

ctron commented May 31, 2024

According to the specification, the Maven ecosystem can carry an additional repository URL: https://ossf.github.io/osv-schema/#affectedpackage-field

The ecosystem string might optionally have a : suffix to denote the remote repository URL that best represents the source of truth for this package, without a trailing slash (e.g. Maven:https://maven.google.com). If this is omitted, this is assumed to be the Maven Central repository (https://repo.maven.apache.org/maven2).

Right now the Ecosystem::Maven variant doesn't support this.

@gcmurphy
Copy link
Owner

gcmurphy commented Jun 1, 2024

Good catch. In hindsight it would be nice to have a more generic solution for the versioned ecosystems like Debian and Alpine too.

@ctron
Copy link
Contributor Author

ctron commented Jun 3, 2024

Maybe a (breaking) change could be to have Ecosystem::Maven(String) or Ecosystem::Maven{group_id: String}?

I can come up with a PR if that helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants