New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug report: Base58 wrong conversion #1742

Closed

wackazong opened this issue Feb 29, 2024 · 0 comments · Fixed by #1763

Labels

bug

wackazong commented Feb 29, 2024

Describe the bug
The base58 implementation is producing incorrect results.

To Reproduce

Go to '...'
The result must be 16 times "1", not 17 times
Compare with the invert operation which is also wrong: https://gchq.github.io/CyberChef/#recipe=From_Base58('123456789ABCDEFGHJKLMNPQRSTUVWXYZabcdefghijkmnopqrstuvwxyz',true)To_Decimal('Space',false)&input=MTExMTExMTExMTExMTExMQ
This gives me back 18 bytes, not 16 bytes.

Expected behaviour
Correct base58 string generation

wackazong added the bug label

zb3 mentioned this issue

Fix Base58 handling of strings with only null characters #1763

Merged

a3957273 closed this as completed in #1763

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment