-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
string refs
are considered legacy
#208
Comments
We should change how the refs are handled. Thoughts, @gcanti? |
Do RN log some warnings about this? |
There are no warnings while the app is running or in the console, but they'll be deprecated soon. |
"Soon" means react v16 I guess, as removing string refs is a breaking change. We can wait for an actual deprecation (+ possibly other breaking changes coming in the v16 release) |
Bumping this React 16.2 is out and this might be changing in 16.3 with the introduction of
https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs |
It's already showing a warning btw |
Hello, this warning is constantly showing in all these components. I don't know when will it be definitely deprecated, but it kind of bothers to see these warnings poping up. Would you please consider uppering this issue's priority? Here is the warning message: Warning: Component "DatePicker" contains the string ref "input". Support for string refs will be removed in a future major release. This case cannot be automatically converted to an arrow function. We ask you to manually fix this case by using useRef() or createRef() instead. Learn more about using refs safely here: https://fb.me/react-strict-mode-string-ref Thanks in advance! |
According to the official documentation, string
refs
will likely be deprecated in the future, and callbackrefs
are preferred.Cf. https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-string-refs.md
The text was updated successfully, but these errors were encountered: