Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Fix issues detected by ASAN #480

Merged
merged 2 commits into from
Nov 17, 2022
Merged

bug: Fix issues detected by ASAN #480

merged 2 commits into from
Nov 17, 2022

Conversation

mjcarroll
Copy link
Contributor

🦟 Bug fix

Summary

A few issues found by ASAN.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Nov 16, 2022
@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Merging #480 (f4629cd) into gz-common5 (10c22d5) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@              Coverage Diff               @@
##           gz-common5     #480      +/-   ##
==============================================
- Coverage       80.62%   80.59%   -0.03%     
==============================================
  Files              90       90              
  Lines           10244    10240       -4     
==============================================
- Hits             8259     8253       -6     
- Misses           1985     1987       +2     
Impacted Files Coverage Δ
graphics/include/gz/common/Image.hh 97.05% <ø> (ø)
av/src/VideoEncoder.cc 73.68% <100.00%> (ø)
geospatial/src/Dem.cc 92.30% <100.00%> (-0.07%) ⬇️
graphics/src/Image.cc 80.29% <100.00%> (-0.72%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mjcarroll mjcarroll merged commit 6886bf4 into gz-common5 Nov 17, 2022
@mjcarroll mjcarroll deleted the mjcarroll/asan branch November 17, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants