-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose Vertex & Index raw ptrs for efficient reading #474
Conversation
Codecov Report
@@ Coverage Diff @@
## gz-common5 #474 +/- ##
===========================================
Coverage 80.60% 80.61%
===========================================
Files 90 90
Lines 10237 10241 +4
===========================================
+ Hits 8252 8256 +4
Misses 1985 1985
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I think this could target |
@darksylinc I think at this point, if you want to retarget to |
changes look good. Maybe add tests for the new APIs in SubMesh_TEST.cc |
Signed-off-by: Matias N. Goldberg <dark_sylinc@yahoo.com.ar>
Signed-off-by: Matias N. Goldberg <dark_sylinc@yahoo.com.ar>
0556024
to
b740464
Compare
Signed-off-by: Matias N. Goldberg <dark_sylinc@yahoo.com.ar>
|
The submesh test if failing on macOS. Anyone has any idea why? UPDATE: Nevermind, the info DOES appear. |
Signed-off-by: Matias N. Goldberg <dark_sylinc@yahoo.com.ar>
Test fixed. All tests sre green. |
🎉 New feature
Summary
This PR exposes vertex & index raw ptrs.
It is necessary to significantly improve performance of Ogre2RayQuery.
It is up to caller to ensure this unsafe pointers are read properly and hence its usage is discouraged; only when necessary.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.