Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-plugin-sass): Accept css-loader options #9462

Merged
merged 10 commits into from
Nov 1, 2018
Merged

feat(gatsby-plugin-sass): Accept css-loader options #9462

merged 10 commits into from
Nov 1, 2018

Conversation

dustinhorton
Copy link
Contributor

@dustinhorton dustinhorton commented Oct 27, 2018

v2 changed how dashes/hyphens in class names handled by css modules were treated: #5458. This was burdensome as it required changing all classNames that utilized dashes.

This allows overriding that change, almost entirely by copying prior art from @yeskunall & @pieh (#9237).

@dustinhorton dustinhorton requested a review from a team October 27, 2018 03:54
@dustinhorton dustinhorton changed the title [gatsby-plugin-sass] Accept css-loader-options [gatsby-plugin-sass] Accept css-loader options Oct 27, 2018
@dustinhorton dustinhorton changed the title [gatsby-plugin-sass] Accept css-loader options feat(gatsby-plugin-sass): Accept css-loader options Oct 27, 2018
@dustinhorton
Copy link
Contributor Author

@pieh Need anything else from me?

Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Left a few comments, my biggest concern is about the snapshots, but doesn't look like you'd have done anything to break that so just want to double check!

Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dustinhorton!

@pieh pieh merged commit a55bc13 into gatsbyjs:master Nov 1, 2018
@gatsbot
Copy link

gatsbot bot commented Nov 1, 2018

Holy buckets, @dustinhorton — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
v2 changed how dashes/hyphens in class names handled by css modules were treated: gatsbyjs#5458. This was burdensome as it required changing all `className`s that utilized dashes.

This allows overriding that change, almost entirely by copying prior art from @yeskunall & @pieh (gatsbyjs#9237).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants