Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain light purple selected state in plugin library #4670

Closed
shannonbux opened this issue Mar 23, 2018 · 6 comments
Closed

Maintain light purple selected state in plugin library #4670

shannonbux opened this issue Mar 23, 2018 · 6 comments
Assignees

Comments

@shannonbux
Copy link
Contributor

Problem

I observed someone using the plugin library yesterday, and noticed that this workflow has a painpoint for him:

  1. He selected a plugin from the left-hand cards
  2. On the right hand side of the screen, he scrolled to the bottom of the READme file for that plugin
  3. He wanted to look at other similar plugins that were already pulled up on the left, but didn't remember which plugin he was on, so he clicked on the same plugin name again.
  4. Then he was confused since the READme file didn't change, so he scrolled to the top of the READme file to remind himself what plugin he was looking at.

Solution

When someone clicks a plugin card on the left, if the light purple selected state persisted until they click on another plugin card, they wouldn't have the problem described above.

@KyleAMathews
Copy link
Contributor

@fk we had styles for this right?

@calebsylvest
Copy link

@shannonbux sounds like what you are saying is a Current state needs to be shown on the plugins list. Currently, there is a Hover state, but no Active/Current indicator.

Here's a simple concept to consider if these styles don't already exist:
gatsby-plugin-states

@tsriram tsriram self-assigned this Mar 26, 2018
@tsriram
Copy link
Contributor

tsriram commented Mar 26, 2018

So we have the styles for selected state of a search result card but the logic to check if a result is selected is broken. Before I push a fix for this, is the existing style for the selected plugin enough? Or should I change the style as described above?

This is how it looks with the current styles:

image

@shannonbux

@KyleAMathews
Copy link
Contributor

Yeah, the current styles are fine — let's get it restored first and if we think the styles should be changed, let's do that in a follow-up PR.

@shannonbux
Copy link
Contributor Author

Looks like this is done! Will close and thanks everyone!!!

@fk
Copy link
Contributor

fk commented Apr 3, 2018

Sorry @KyleAMathews, only saw your comment now :-/ (thanks to @shannonbux' last comment from today and Gmail filters finally set up 🎉).

Not opposed to make the current "selected" state clearer, and I also like the hover-state @calebsylvest suggested – seems a bit lighter than the current ones, while still visible enough?

Thanks @tsriram! 🤗<3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants