createRemoteFileNode should parse out the query string from url

[m4rrc0]

Description

When using createRemoteFileNode to fetch images and there are query parameters in the url, the file gets saved with a wrong extension and media type.
For example: to access Firebase assets one will use an url such as https://firebasestorage.googleapis.com/v0/b/[bucket name]/o/image.png?alt=media&token=[some token]

Steps to reproduce

const url = 'https://firebasestorage.googleapis.com/v0/b/test-pushtable-b6bb5.appspot.com/o/assets%2Favataaars_Marc.png?alt=media&token=33f1d5ed-4c19-40f7-a17a-9ab10dcac402'
createRemoteFileNode({
    url,
    store,
    cache,
    createNode,
  })

Expected result

One should get a someHash.png file in cache with correct media type

Actual result

File is named someHash.png?alt=media&token=theToken

Environment

• Gatsby: 1.9.225
• Gatsby-source-filesystem: 1.5.27
• gatsby-cli: 1.1.45
• Node.js version: 9.7.1
• Operating System: Linux

Comments

I could try and make a PR next week but I would like confirmation that this is indeed something we want.
Is there some things I need to be aware of or pay attention to?

[pieh]

You can check #2985 - both code and comments - I had similar problem, but went with different approach so I "workarounded" this issue and ultimately didn't fix this.

[m4rrc0]

Thanks @pieh I hadn't catch that PR.

[KyleAMathews]

What's the problem? The file is being saved as .png which is what you want right?

[m4rrc0]

Humm... no it is not. As I mentioned the name of the file being saved is something like
someHash.png?alt=media&token=theToken.
This is the correct file but it is not processed by Sharp as the extension is not .png and the media type is not image/png...

[KyleAMathews]

What is the extension and mediaType?

[KyleAMathews]

In the File node

[m4rrc0]

application/octet-stream
It is the same issue as pieh mentionned above: #2985
To be honest I probably won't be using Firebase in the end so this is not a priority for me.
I still think other people will end up with the same issue at some point though.

[KyleAMathews]

Due to the high volume of issues, we're closing out older ones without recent activity. Please open a new issue if you need help!