Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert panic (and any console.log) errors to panicOnBuild if the error should stop a build from succeeding #4070

Closed
KyleAMathews opened this issue Feb 16, 2018 · 3 comments

Comments

@KyleAMathews
Copy link
Contributor

/cc @jquense

@anjawaldbauer
Copy link
Contributor

@KyleAMathews Is my understanding correct that you want Gatsby v2 to stop a build on any error or warning? This is exactly what I would want. I would love to help implement this, if you could give a little bit of guidance. I would also very much appreciate if you could explain how to do implement this behavior in Gatsby v1 as an opt-in. Thank you in advance!

@m-allanson
Copy link
Contributor

@anjawaldbauer This has been implemented in v2 as a panicOnBuild method of the reporter. I don't think there are any plans to backport it to v1, as that effort could be spent getting v2 out more quickly :)

@KyleAMathews
Copy link
Contributor Author

Yeah, let's close this. It won't be back-ported. There's still work to sort out which errors/warnings should use this but that can be an on-going project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants