Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-plugin-manifest): Delete cacheDigest from generated webmanifest #33966

Merged
merged 1 commit into from
Nov 17, 2021
Merged

Conversation

buzinas
Copy link
Contributor

@buzinas buzinas commented Nov 13, 2021

Description

Currently Gatsby is adding a cacheDigest property to the root of the generated webmanifest.

It is an invalid property and triggers an error when running a PWA test on Gatsby projects.

See:

image

Documentation

See https://webhint.io/docs/user-guide/hints/hint-manifest-is-valid/?source=devtools.

cacheDigest is an invalid property and triggers an error when running a PWA test on Gatsby projects
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 13, 2021
@LekoArts LekoArts changed the title Delete cacheDigest from generated webmanifest fix(gatsby-plugin-manifest): Delete cacheDigest from generated webmanifest Nov 17, 2021
@LekoArts LekoArts added topic: plugins-PWA Issues related to PWA: the gatsby-plugin-offline and gatsby-plugin-manifest plugins and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Nov 17, 2021
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LekoArts LekoArts merged commit 27cf7e7 into gatsbyjs:master Nov 17, 2021
@buzinas buzinas deleted the patch-1 branch November 17, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: plugins-PWA Issues related to PWA: the gatsby-plugin-offline and gatsby-plugin-manifest plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants