Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gatsby-plugin-google-analytics]Wait for the title update #3362

Merged
merged 1 commit into from
Jan 3, 2018

Conversation

ntwcklng
Copy link
Contributor

As Kyle suggested, we should wrap the Google-Analytics function into a setTimeout so it waits until the title is updated.

see #2478

@ntwcklng ntwcklng changed the title Wait for the title update [gatsby-plugin-google-analytics]Wait for the title update Dec 29, 2017
@KyleAMathews
Copy link
Contributor

Deploy preview failed.

Built with commit df00bb7

https://app.netlify.com/sites/using-glamor/deploys/5a46313f81987666e30ebdb7

@ntwcklng
Copy link
Contributor Author

Mhhh, not sure if this failed because of my commit:

1:16:54 PM: Failing build: Failed to deploy site
1:18:04 PM: failed during stage 'deploying site': Failed to execute deploy: &{0 } (*models.Error) is not supported by the TextConsumer, can be resolved by supporting TextUnmarshaler interface
1:18:24 PM: Failed to inform the API about a failed build, please retry the build or contact support
1:18:24 PM: Finished processing build request in 5m35.32850105s

@KyleAMathews
Copy link
Contributor

Thanks for the fix!

And yeah — ignore the build failure — we're moving to our own integration test framework soon that'll be more reliable.

@KyleAMathews KyleAMathews merged commit e883ab3 into gatsbyjs:master Jan 3, 2018
@ntwcklng ntwcklng deleted the fix/ga-plugin-title branch January 3, 2018 12:18
wardpeet added a commit that referenced this pull request Feb 15, 2019
There is still a problem with title and path not being correct while navigating across a page.

As referenced in: #9139
Solution made in:  #2478 and #3362

For some reason the previous solution is being overwritten

Co-authored-by: Ward Peeters <ward@coding-tech.com>
@jlengstorf
Copy link
Contributor

Hiya @ntwcklng! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
  2. If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜

pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
…byjs#10917)

There is still a problem with title and path not being correct while navigating across a page.

As referenced in: gatsbyjs#9139
Solution made in:  gatsbyjs#2478 and gatsbyjs#3362

For some reason the previous solution is being overwritten

Co-authored-by: Ward Peeters <ward@coding-tech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants