-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gatsby-plugin-google-analytics]Wait for the title update #3362
Conversation
Deploy preview failed. Built with commit df00bb7 https://app.netlify.com/sites/using-glamor/deploys/5a46313f81987666e30ebdb7 |
Mhhh, not sure if this failed because of my commit:
|
Thanks for the fix! And yeah — ignore the build failure — we're moving to our own integration test framework soon that'll be more reliable. |
Hiya @ntwcklng! 👋 This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here. Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! 💪💜 |
…byjs#10917) There is still a problem with title and path not being correct while navigating across a page. As referenced in: gatsbyjs#9139 Solution made in: gatsbyjs#2478 and gatsbyjs#3362 For some reason the previous solution is being overwritten Co-authored-by: Ward Peeters <ward@coding-tech.com>
As Kyle suggested, we should wrap the Google-Analytics function into a
setTimeout
so it waits until the title is updated.see #2478