fix(mini-css-extract): don't use loader in ssr #29801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
commented
Feb 26, 2021
Comment on lines
-48
to
+49
| stage: `develop`, | ||
| stage, |
There was a problem hiding this comment.
welp those tests for various stages were only repeating develop stage ;)
pieh
commented
Feb 26, 2021
| @@ -111,7 +111,7 @@ | |||
| "memoizee": "^0.4.15", | |||
| "micromatch": "^4.0.2", | |||
| "mime": "^2.4.6", | |||
| "mini-css-extract-plugin": "1.3.8", | |||
| "mini-css-extract-plugin": "1.3.9", | |||
There was a problem hiding this comment.
I leave this pinned, just so we can use renovate bot to verify before upgrading
wardpeet
approved these changes
Feb 26, 2021
pieh
added
topic: webpack/babel
vladar
pushed a commit
that referenced
this pull request
Feb 26, 2021
(cherry picked from commit b2d6617)
vladar
pushed a commit
that referenced
this pull request
Feb 26, 2021
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This moves back to setup we had in v2 pretty much.
Related Issues
#29773
webpack-contrib/mini-css-extract-plugin#703 (comment)