fix: make minicss-extract-plugin compatible with plugins #29599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
wardpeet
commented
Feb 19, 2021
| @@ -8,7 +8,8 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@babel/runtime": "^7.12.5", | |||
| "sass-loader": "^10.1.0" | |||
| "sass-loader": "^10.1.0", | |||
| "resolve-url-loader": "^3.1.2" | |||
There was a problem hiding this comment.
This was a missing dependency
wardpeet
force-pushed
the
fix/css-plugins
branch
3 times, most recently
from
dbdca1f to
f66fef3
Compare
wardpeet
force-pushed
the
fix/css-plugins
branch
from
bb7f7b2 to
cfa707f
Compare
pieh
added
topic: webpack/babel
pieh
approved these changes
Feb 19, 2021
This was referenced Mar 17, 2021
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mini-css-extract-plugin is used in production and development.
We need to cleanup the conditionals and remove the errors it produces.
Related Issues
[ch25386]