Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-google-analytics): Fix gatsby-node so we still have a warning on older gatsby versions #27495

Merged
merged 1 commit into from
Oct 16, 2020
Merged

fix(gatsby-plugin-google-analytics): Fix gatsby-node so we still have a warning on older gatsby versions #27495

merged 1 commit into from
Oct 16, 2020

Conversation

MichaelDeBoey
Copy link
Contributor

Description

As discussed with @mxstbr in #27242 (comment), I added onPreInit again in case GATSBY_EXPERIMENTAL_PLUGIN_OPTION_VALIDATION isn't true

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Oct 16, 2020
@MichaelDeBoey MichaelDeBoey mentioned this pull request Oct 16, 2020
Merged
mxstbr
mxstbr approved these changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@mxstbr mxstbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, I love it! Thank you!

@mxstbr mxstbr merged commit 9797828 into gatsbyjs:master Oct 16, 2020
@MichaelDeBoey MichaelDeBoey deleted the fix-plugin-google-analytics-gatsby-node branch October 16, 2020 17:29
@LekoArts LekoArts removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxstbr mxstbr mxstbr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelDeBoey @mxstbr @LekoArts