fix(gatsby-plugin-postcss): Delete invalid plugins property from outer options object. #27430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
…r options object.
richardxia
force-pushed
the
fix-gatsby-plugin-postcss-plugins-nesting-2
branch
from
a79c2fb
to
1a1a2de
Compare
LekoArts
removed
the
status: triage needed
LekoArts
approved these changes
Oct 14, 2020
|
Published in |
|
Thank you so much! This time I can really confirm that the latest package works in my app. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a followup to #27418, where I realized that my fix didn't completely fix the problem. See this comment of mine that describes the issue in a bit more detail.
The steps for reproducing are still the same as #27417, and the error message is still the same, but the internal data structures in the code are a little bit different than before.
In this PR, I have restored the
deletestatement back to what it was previously, since I think it was intentionally trying to delete the property at the outer level and not the inner level. I don't feel that I understand why this is happening, so I'd appreciate some input on whether this is the right change to make.This time I tested it by running through my steps for reproducing again, and then once again hot-editing my
node_modules/directory with the exact same changes in this PR, so this time I at least feel like I've done a better job of doing a full integration test, but I'd appreciate input on anything else I should test.Documentation
No documentation changes, as this should hopefully make it work properly.
Related Issues
Addresses #27417 (for real, this time, hopefully).