Retext-spell needs to run on PRs

[marcysutton]

Description

With #24372, the retext-spell bot checks spelling against a dictionary.txt file. It's working okay, except that it doesn't run on PRs. This results in changes going in without a notification of issues with the dictionary, causing builds on master to fail.

Contributors and team members should know whether a PR actually passes the linter, rather than guessing or causing a broken build.

Motivation

We need the status checks to accurately reflect the status of a PR, including spelling/dictionary issues, so we don't have to come back in and fix them after the fact (and cause a headache for other PR authors).

Steps to reproduce

Look at the checks in this PR, and see how ci/circleci: lint says "Your tests passed on CircleCI!"

When this PR was merged to master, it broke the build: https://app.circleci.com/pipelines/github/gatsbyjs/gatsby/46391/workflows/40268339-bbd9-4ad1-a883-2c3ddc6def23/jobs/472848

Expected result

The linter should fail code at PR stage, not when merged to master. I wouldn't expect it to automatically fix issues with the dictionary, but at least warn contributors when it's failing on a branch.

Actual result

Dictionary checks don't run on PRs, so we miss linting issues. This is unsustainable.

Environment

N/A. this happens for all GitHub users.

[github-actions]

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

[jaebradley]

@marcysutton is this still an issue?

Here's a test commit on a PR (e627dd4) where it seems like documentation linting is working on a per PR-basis

I wonder if the reason why the lint:docs command successfully completed on the branch was that the repository (https://github.com/mistryvatsal/gatsby) hadn't rebased before merge and was missing some essential changes/ files that had been merged into master.

For example, the repository (which doesn't seem to have been modified since the PR referenced in this issue was merged) seems to have a different .remarkrc.js file from what was on master on time of merge.

When I copy the .remarkrc.js configuration in the above repository, I can get documentation linting to pass even though I've introduced a docs markdown file with typos (30ba769)

Build is here: https://app.circleci.com/pipelines/github/gatsbyjs/gatsby/49230/workflows/73abd618-11da-4f70-ab26-de264f66f6e2/jobs/504345

I could totally be missing something - I mostly stumbled upon this issue because I've been looking to contribute and this seemed like a good issue to help with; unfortunately, I am unsure if this is still a problem, but if it is, I'm happy to help out if I can!

[LekoArts]

Yeah, that seems correct that it works now and the PR in question had an outdated fork of the repository.