fix(gatsby-plugin-manifest): ensure icon_options is stripped #12907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moonmeister
added
type: bug
wardpeet
approved these changes
Mar 28, 2019
Co-Authored-By: moonmeister <moonmeister@users.noreply.github.com>
Co-Authored-By: moonmeister <moonmeister@users.noreply.github.com>
|
@wardpeet I'll fix those other lets in my clean up pr |
…o manifest-options-fix * 'manifest-options-fix' of github.com:gatsbyjs/gatsby: Update packages/gatsby-plugin-manifest/src/__tests__/gatsby-node.js Update packages/gatsby-plugin-manifest/src/__tests__/gatsby-node.js
DSchau
approved these changes
Mar 28, 2019
Co-Authored-By: moonmeister <moonmeister@users.noreply.github.com>
|
I think this is ready. Builds are failling for all PRs right not cause of a CI issue. |
DSchau
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Here are those bug fixes, and cleanup for the new
icon_options. I also added tests.Related Issues
#12794