-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Loki to npm test script #11676
Comments
Good question. For the most part this doesn't matter for 99% of contributors because they don't touch code related to nodes data store / sorting and filtering nodes when querying (things that are different when using loki), so maybe we could add this as connivence script ( |
how do we feel about running jest:loki in ci when gatsby-core changes? |
We can always add more concurrency correct if builds are getting slow? |
I like this idea 👍 |
Oh I misread - we already run the Loki tests in CI |
@m-allanson do we? I don't think so 😊 |
@wardpeet we do: https://github.com/gatsbyjs/gatsby/blob/master/.circleci/config.yml#L58-L59 it just wasn't worth to add another check, so it was added as step to unit tests (it adds ~30 secs to test time) |
Now that we are testing with Loki in CI, should we also adjust the npm
jest
script (or add ajest:loki
script?)The text was updated successfully, but these errors were encountered: