Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Loki to npm test script #11676

Closed
stefanprobst opened this issue Feb 10, 2019 · 7 comments
Closed

Add Loki to npm test script #11676

stefanprobst opened this issue Feb 10, 2019 · 7 comments
Labels
type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change

Comments

@stefanprobst
Copy link
Contributor

Now that we are testing with Loki in CI, should we also adjust the npm jest script (or add a jest:loki script?)

@pieh
Copy link
Contributor

pieh commented Feb 11, 2019

Good question. For the most part this doesn't matter for 99% of contributors because they don't touch code related to nodes data store / sorting and filtering nodes when querying (things that are different when using loki), so maybe we could add this as connivence script (jest:loki), but don't run it when running regular jest?

@pieh pieh added the type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change label Feb 11, 2019
@wardpeet
Copy link
Contributor

how do we feel about running jest:loki in ci when gatsby-core changes?

@KyleAMathews
Copy link
Contributor

We can always add more concurrency correct if builds are getting slow?

@m-allanson
Copy link
Contributor

how do we feel about running jest:loki in ci when gatsby-core changes?

I like this idea 👍

@m-allanson
Copy link
Contributor

Oh I misread - we already run the Loki tests in CI

@wardpeet
Copy link
Contributor

@m-allanson do we? I don't think so 😊

@pieh
Copy link
Contributor

pieh commented Feb 12, 2019

@wardpeet we do: https://github.com/gatsbyjs/gatsby/blob/master/.circleci/config.yml#L58-L59 it just wasn't worth to add another check, so it was added as step to unit tests (it adds ~30 secs to test time)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Development

No branches or pull requests

5 participants