fix(gatsby-remark-autolink-headers): remove accents from anchors

[windkomo]

Removing accent characters from URLs (and thus anchors links) seems preferable to me.
What do you guys think?

[pieh]

This is potentially breaking change (links would potentially change). It's not a blocker - just documenting that we would need bump major version for this change.

I feel like change like this warrant adding some tests to cover cases of headings with accent characters to make sure we don't introduce regressions later on.

[pieh]

I'm not sure on this, but are accented characters invalid as element IDs / link targets? If it's not invalid maybe instead of breaking change we could add plugin option to convert to latin (or whatever @sindresorhus/slugify does)?

[pieh]

So did some code reading and it seems we can add option to optionally use https://lodash.com/docs/4.17.11#deburr to remove accents

[windkomo]

@pieh thanks for taking a look!
Accented characters are not invalid in URLs, but to me they are likely to cause issues like encoding.
Slugifying strings should always remove diacritics to avoid any kind of encoding issue so I was very surprised to see accented characters in my address bar 😄
Accented characters makes it harder to type URLs too, if you don't put the right char then it will 404.

[windkomo]

@pieh I think your solution to keep the github slugger thing, and optionally use lodash deburr to remove accents is good. I still think removing accents should be the default behavior, what do you think about introducing this as a feature for now and as a breaking change if we want to later?

[pieh]

what do you think about introducing this as a feature for now and as a breaking change if we want to later?

This sounds perfect to me! We just don't have enough data to make informed decision for all the people, but at least providing option would unblock people that definitely want this behaviour.

[windkomo]

@pieh I made some changes, let me know if there's anything wrong!

[wardpeet]

This looks great! I love that removeAccents is optional.

[gatsbot]

Holy buckets, @windkomo — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!