Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-plugin-google-analytics): Pass event object to the user's onClick callback in OutboundLink #11340

Merged
merged 1 commit into from
Jan 28, 2019

Conversation

maciekmaciej
Copy link
Contributor

Description

Pass event object to the user's onClick callback

@maciekmaciej maciekmaciej changed the title Pass event object to the user's onClick callback [gatsby-plugin-google-analytics ] Pass event object to the user's onClick callback Jan 27, 2019
@pieh pieh changed the title [gatsby-plugin-google-analytics ] Pass event object to the user's onClick callback feat(gatsby-plugin-google-analytics): Pass event object to the user's onClick callback in OutboundLink Jan 27, 2019
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @asistapl! :)

@pieh pieh merged commit e81b246 into gatsbyjs:master Jan 28, 2019
@gatsbot
Copy link

gatsbot bot commented Jan 28, 2019

Holy buckets, @asistapl — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

wardpeet pushed a commit that referenced this pull request Feb 11, 2019
@dance2die
Copy link
Contributor

Thank you guys. This is indeed working now~

I had a trouble of having to add event listeners for ouboundlink generated anchors but now it works perfect.

https://github.com/dance2die/landing-page-v3-gatsby/blob/master/src/components/util/index.js#L5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants