Skip to content

Commit 68cb7b6

Browse files
committed
Rethrow errors without specific handling
1 parent 5f19812 commit 68cb7b6

File tree

2 files changed

+2
-16
lines changed

2 files changed

+2
-16
lines changed

packages/gatsby-remark-code-repls/src/__tests__/gatsby-node.js

-12
Original file line numberDiff line numberDiff line change
@@ -135,18 +135,6 @@ describe(`gatsby-remark-code-repls`, () => {
135135
}
136136
})
137137

138-
it(`should wrap any non-error rejection from recursive-readdir in an Error instance`, async () => {
139-
const rejectionMessage = `an error message`
140-
141-
readdir.mockRejectedValue(rejectionMessage)
142-
143-
try {
144-
await createPages(createPagesParams)
145-
} catch (err) {
146-
expect(err).toEqual(Error(rejectionMessage))
147-
}
148-
})
149-
150138
it(`should not load any external packages by default`, async () => {
151139
readdir.mockResolvedValue([`file.js`])
152140

packages/gatsby-remark-code-repls/src/gatsby-node.js

+2-4
Original file line numberDiff line numberDiff line change
@@ -75,9 +75,7 @@ exports.createPages = async (
7575
}
7676
})
7777
} catch (error) {
78-
if (error instanceof Error) {
79-
throw error
80-
}
81-
throw Error(error)
78+
// retrow errors upstream
79+
throw error
8280
}
8381
}

0 commit comments

Comments
 (0)