Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make generateRedirectObjectsForPermanentRedirects default to true #78

Open
jariz opened this issue Jun 25, 2019 · 2 comments
Open

Make generateRedirectObjectsForPermanentRedirects default to true #78

jariz opened this issue Jun 25, 2019 · 2 comments
Milestone
1.0

Comments

@jariz
Copy link
Collaborator

jariz commented Jun 25, 2019

https://github.com/jariz/gatsby-plugin-s3/blob/53c08f55486b698c7e5957f04202fe81a7b98796/src/constants.ts#L83-L84
@jariz jariz added this to the 1.0 milestone Jun 25, 2019
@jariz jariz mentioned this issue Jun 25, 2019
Open
@jariz
Copy link
Collaborator Author

jariz commented Jun 25, 2019

also rename it?? or just remove it entirely???.
eitherway that name is awful.

@YoshiWalsh
Copy link
Collaborator

I like the name, it's descriptive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@jariz @YoshiWalsh