Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make updating website config optional #52

Closed
tscheepers opened this issue Mar 22, 2019 · 4 comments
Closed

Make updating website config optional #52

tscheepers opened this issue Mar 22, 2019 · 4 comments
Labels
enhancement New feature or request priority: medium

Comments

@tscheepers
Copy link

I have a use case in which I wrote custom S3 redirect rules. Because the deploy script updates the website config, these rules are removed each time I deploy. It would be wonderful if writing the website configuration would be optional.

https://github.com/jariz/gatsby-plugin-s3/blob/master/src/bin.ts#L154-L170

@YoshiWalsh
Copy link
Collaborator

I think it's worth providing an option for this, but disabling routing rules will obviously disable serverside redirects & rewrites as well. (Well, 301 redirects might be preserved using file-based redirects instead, #49)

We should also consider making a config property for custom redirect rules, then when we deploy the website config we can include generated redirect rules as well as the user's custom-specified rules.

@jariz jariz added the enhancement New feature or request label Mar 25, 2019
@jariz jariz added this to the 1.0 milestone May 16, 2019
@jariz
Copy link
Collaborator

jariz commented Jun 17, 2019

fixed in #72 (which was a duplicate of this issue actually it seems?)

@jariz jariz closed this as completed Jun 17, 2019
@YoshiWalsh
Copy link
Collaborator

72 was a PR, so technically not a duplicate.

@jariz
Copy link
Collaborator

jariz commented Jun 17, 2019

ah woops, you're right

@jariz jariz removed this from the 1.0 milestone Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority: medium
Projects
None yet
Development

No branches or pull requests

3 participants