-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make updating website config optional #52
Comments
I think it's worth providing an option for this, but disabling routing rules will obviously disable serverside redirects & rewrites as well. (Well, 301 redirects might be preserved using file-based redirects instead, #49) We should also consider making a config property for custom redirect rules, then when we deploy the website config we can include generated redirect rules as well as the user's custom-specified rules. |
fixed in #72 (which was a duplicate of this issue actually it seems?) |
72 was a PR, so technically not a duplicate. |
ah woops, you're right |
I have a use case in which I wrote custom S3 redirect rules. Because the deploy script updates the website config, these rules are removed each time I deploy. It would be wonderful if writing the website configuration would be optional.
https://github.com/jariz/gatsby-plugin-s3/blob/master/src/bin.ts#L154-L170
The text was updated successfully, but these errors were encountered: